590072 - XP specific styling of menu buttons in popup notifications

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Peter Henkel [:Terepin]]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100823 Minefield/4.0b5pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100823 Minefield/4.0b5pre

Someone from UX team should post a mockup.

Reproducible: Always

Comment 1

[Stephen Horlander [:shorlander]]

Attachment: Windows XP Arrow Panel Design

Comment 2

[:Margaret Leibovic]

Attachment: patch

Comment 3

[:Margaret Leibovic]

Attachment: screenshot

Comment 4

[:Margaret Leibovic]

(In reply to comment #2)
> Created attachment 488046 [details] [diff] [review]
> patch

Note: I built this patch on top of the patch for bug 577928.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 488046 [details] [diff] [review]
patch

>diff --git a/toolkit/themes/winstripe/global/notification.css b/toolkit/themes/winstripe/global/notification.css
>--- a/toolkit/themes/winstripe/global/notification.css
>+++ b/toolkit/themes/winstripe/global/notification.css
>@@ -58,68 +58,90 @@ notification[type="critical"] .messageIm
> }
> 
> /* Popup notification button */
> 
> .popup-notification-menubutton {
>   margin-top: 17px;
> }
> 
>-%ifdef WINSTRIPE_AERO

Use %ifdef XP_WIN here, since winstripe is the basis for various non-Windows toolkit themes.

Comment 6

[:Margaret Leibovic]

Attachment: revised patch

Comment 7

[:Margaret Leibovic]

http://hg.mozilla.org/mozilla-central/rev/8bc89d6577d7