590073 - Classic specific styling of arrow panels

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Peter Henkel [:Terepin]]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100823 Minefield/4.0b5pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100823 Minefield/4.0b5pre

Someone from UX team should post a mockup.

Reproducible: Always

Comment 1

[:Margaret Leibovic]

Attachment: current doorhanger on XP with classic theme

This is a general arrow panel theme problem. What do we want them to look like? Right now they're just picking up the aero or XP styling from the OS. I feel like the XP style could work if we change the color of the panel. Stephen, thoughts?

Comment 2

[alex_mayorga]

Attachment: "Glassy" door hanger on "Windows Classic" theme

I think this is All Windows, not just 7 as I have the same problem on Mozilla/5.0 (Windows NT 6.0; rv:2.0b8pre) Gecko/20101019 Firefox/4.0b8pre ID:20101019041714

Comment 3

[Csaba Kozák [:WonderCsabo]]

(In reply to comment #2)
> Created attachment 484337 [details]
> "Glassy" door hanger on "Windows Classic" theme


I don't like it, looks totally outlandish on Classic theme.

Comment 4

[Dão Gottwald [:dao]]

This currently breaks high-contrast themes too.

Comment 5

[Dão Gottwald [:dao]]

Attachment: screenshot, using high contrast mode

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 498125 [details] [diff] [review]
patch

>+%ifdef XP_WIN
>+@media all and (-moz-windows-default-theme) {
> panel[type="arrow"][side="top"],
> panel[type="arrow"][side="bottom"] {
>   margin-left: -25px;
>   margin-right: -25px;
> }
> 
> panel[type="arrow"][side="left"],
> panel[type="arrow"][side="right"] {
>@@ -164,16 +226,18 @@ panel[type="arrow"][side="right"] {
>   margin-right: -5px;
> %else
>   margin-top: 6px;
>   margin-bottom: 6px;
>   margin-left: -12px;
>   margin-right: -4px;
> %endif
> }
>+}
>+%endif

I'm going to adjust the indentation here when landing this.

Comment 8

[Dão Gottwald [:dao]]

Attachment: screenshot, high contrast mode, patched

Comment 9

[[e-mail]]

Comment on attachment 498125 [details] [diff] [review]
patch

The Windows build that I have available isn't showing arrow panels properly :-(
But I tried this on Linux and it works well. I didn't look at the code though.

Comment 10

[[e-mail]]

Comment on attachment 498125 [details] [diff] [review]
patch

I found out what was wrong with my Windows build (I had a bad merge in popup.css) and this looks good in Windows Classic too.

Still only a visual review though!

Comment 11

[Dão Gottwald [:dao]]

(In reply to comment #10)
> Still only a visual review though!

FWIW, it's mostly the same as the already existing non-classic code, just some different dimensions here and there, so this should be fine.

Comment 12

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/fb629ae54510

Comment 13

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381