Closed Bug 590073 Opened 9 years ago Closed 9 years ago

Classic specific styling of arrow panels

Categories

(Toolkit :: Themes, defect, major)

All
Windows 7
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla2.0b9
Tracking Status
blocking2.0 --- final+

People

(Reporter: Terepin, Assigned: dao)

References

Details

(Keywords: access, regression)

Attachments

(5 files)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100823 Minefield/4.0b5pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100823 Minefield/4.0b5pre

Someone from UX team should post a mockup.

Reproducible: Always
Blocks: 577927
Version: unspecified → Trunk
This is a general arrow panel theme problem. What do we want them to look like? Right now they're just picking up the aero or XP styling from the OS. I feel like the XP style could work if we change the color of the panel. Stephen, thoughts?
I think this is All Windows, not just 7 as I have the same problem on Mozilla/5.0 (Windows NT 6.0; rv:2.0b8pre) Gecko/20101019 Firefox/4.0b8pre ID:20101019041714
(In reply to comment #2)
> Created attachment 484337 [details]
> "Glassy" door hanger on "Windows Classic" theme


I don't like it, looks totally outlandish on Classic theme.
This currently breaks high-contrast themes too.
Blocks: 554937
No longer blocks: 577927
Status: UNCONFIRMED → NEW
blocking2.0: --- → ?
Component: Theme → Themes
Ever confirmed: true
Keywords: access, sec508
Product: Firefox → Toolkit
QA Contact: theme → themes
Summary: Classic specific styling of Doorhanger → Classic specific styling of arrow panels
Assignee: nobody → dao
Severity: normal → major
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
Attachment #498125 - Flags: review?(enndeakin)
Comment on attachment 498125 [details] [diff] [review]
patch

>+%ifdef XP_WIN
>+@media all and (-moz-windows-default-theme) {
> panel[type="arrow"][side="top"],
> panel[type="arrow"][side="bottom"] {
>   margin-left: -25px;
>   margin-right: -25px;
> }
> 
> panel[type="arrow"][side="left"],
> panel[type="arrow"][side="right"] {
>@@ -164,16 +226,18 @@ panel[type="arrow"][side="right"] {
>   margin-right: -5px;
> %else
>   margin-top: 6px;
>   margin-bottom: 6px;
>   margin-left: -12px;
>   margin-right: -4px;
> %endif
> }
>+}
>+%endif

I'm going to adjust the indentation here when landing this.
Keywords: regression
Attachment #498125 - Flags: review?(neil)
Comment on attachment 498125 [details] [diff] [review]
patch

The Windows build that I have available isn't showing arrow panels properly :-(
But I tried this on Linux and it works well. I didn't look at the code though.
Attachment #498125 - Flags: review?(neil) → review+
Attachment #498125 - Flags: review?(enndeakin) → approval2.0?
Comment on attachment 498125 [details] [diff] [review]
patch

I found out what was wrong with my Windows build (I had a bad merge in popup.css) and this looks good in Windows Classic too.

Still only a visual review though!
(In reply to comment #10)
> Still only a visual review though!

FWIW, it's mostly the same as the already existing non-classic code, just some different dimensions here and there, so this should be fine.
blocking2.0: ? → final+
Attachment #498125 - Flags: approval2.0?
http://hg.mozilla.org/mozilla-central/rev/fb629ae54510
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
Depends on: 620658
Blocks: 604257
You need to log in before you can comment on or make changes to this bug.