User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100823 Minefield/4.0b5pre Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100823 Minefield/4.0b5pre If you attempt to use bookmarks keyword, and you use an uppercase letter, it won't work Reproducible: Always Steps to Reproduce: 1. Make a keyword "g" or "G" for a bookmark 2. Enter "G" in urlbar Actual Results: keyword doesn't work Expected Results: you go to bookmarked page :) See bug 572030 comment 30 for possible reason.\
asking blocking for broken functionality
"no longer case insensitive" is not exactly right - if you make an uppercase keyword, you can still only access by typing it in lowercase. So it's as if keywords were stored after converting to lowercase, but then matching happens to what was directly typed.
right, the problem is with the comparator that looks for the requested keyword than the lowercased keyword
Created attachment 469438 [details] [diff] [review] patch v1.0
Created attachment 469882 [details] [diff] [review] patch v1.1 ready to qimport
Hmm, ToLowerCase does Unicode aware lowercasing. Is that necessary here?
are you arguing about perf? keywords are nsString and can contain anything
This was marked as ride-along but doesn't apply on m-c.
I'd really expect people to set non-ASCII keywords in language that have non-ASCII characters in usual language - e.g. even i German, I'd expect people to use äöü in keywords and expect then to work when using ÄÖÜ in the location bar to call them up.