590369 - Didn't get any talos runs for 3.6.9 build1

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Linux sendchange:
    master: production-master01.build.mozilla.org:9009
    branch: mozilla-1.9.2-release-linux-talos
    revision: 340d4a429fe6
    comments: 
    user: sendchange
    files: ['http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/3.6.9-candidates/build1/linux-i686/en-US/firefox-3.6.9.tar.bz2']
but didn't get any talos runs showing up on
  http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox3.6-Release
nor any jobs for builders like 'Rev3 Fedora 12 release-mozilla-1.9.2 talos tp4' on the buildbot master. All platforms.

Comment 1

[Armen [:armenzg]]

Attachment: fix talosBranch name

Hi Nick,
I have looked at this code during beta 3 and there was some refactoring done for schedulerDB which we followed up with a port to 0.7.10 (releases master - bug 585098).
Ben and I just looked at the following patch:
https://bug585098.bugzilla.mozilla.org/attachment.cgi?id=465231
and I think here is the code that is incorrect:
-        talosBranch = "%s-release-%s" % (self.branchName, self.platform)
+        talosBranch = "%s-release-%s-talos" % (self.branchName, self.platform)
since we had fixed it to have "release-" as a prefix rather than infix:
-    branch += "-release"
+    branch = "release-" + branch

Unit tests worked because the branch name was correctly constructed:
http://mxr.mozilla.org/build/source/buildbot-configs/mozilla2/release_master.py#263

Here are the branch names of the sendchanges that were used during the 3.6.9 release:
    branch: mozilla-1.9.2-release-linux-talos
    branch: release-mozilla-1.9.2-linux-opt-unittest
As you can see for unit tests we are following the new naming.


Catlee is this patch correct? Not that I have time to test it but I believe this should do the trick.

Comment 2

[Chris AtLee [:catlee]]

Comment on attachment 469056 [details] [diff] [review]
fix talosBranch name

Looks good.

Please land this both on the default and 0.8.0 branch.

Comment 3

[Armen [:armenzg]]

Comment on attachment 469056 [details] [diff] [review]
fix talosBranch name

http://hg.mozilla.org/build/buildbotcustom/rev/098ce1881309 (buildbot-0.8.0)
http://hg.mozilla.org/build/buildbotcustom/rev/be46325d78e4 (default)

Reconfigured pm to make sure the next release picks up this change.

Comment 4

[Armen [:armenzg]]

Let's see in the next release if this gets fixed.