Closed Bug 590816 Opened 11 years ago Closed 1 year ago

about:support styled to match other about pages

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: shift9999, Unassigned)

References

Details

(Keywords: polish)

Attachments

(4 files, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100825 Minefield/4.0b5pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100825 Minefield/4.0b5pre

I have been poking around the about pages and came up with an about:support page that matches the other about pages nicely. It reuses all of the styles from the other pages and does not change any strings. Please see the attached screen shot for a preview. I have the modified source files ready to go if interested.

Reproducible: Always
Attached image Preview Screenshot (obsolete) —
Keywords: polish
you can use the feedback flag to get feedback on your screenshot from someone in ux team. Personally I like it, it looks cleaner.
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: aboutsupport styled to match other about pages → about:support styled to match other about pages
Attachment #469324 - Flags: feedback?(limi)
Is this bug dead? 

Anyway, you should use left-aligned coloumns, it's hard to read centered ones.
A reviewer from the the UX team never got back to me. Right now it's set to feedback "limi", is there someone else from the UX team I should flag?
I think you should ask feedback from shorlander or alex.
But change the screenshot to the one with left-aligned columns, first.
Attached image Preview Screenshot Left Aligned (obsolete) —
Here is an updated screenshot with the columns left aligned.
Requesting review.
Attachment #479292 - Flags: feedback?(shorlander)
Attachment #469324 - Flags: feedback?(limi) → feedback?(shorlander)
Mr. Horlander has not responded to the feedback request in some time, is there someone else that could provide some input?
Alex Faaborg, maybe. If he wont, ask Dao.
Comment on attachment 469324 [details]
Preview Screenshot

I have updated feedback requests to reflect comments.
Attachment #469324 - Flags: feedback?(shorlander) → feedback?(dao)
Attachment #479292 - Flags: feedback?(shorlander) → feedback?(dao)
Hmm, maybe you should ask feedback from Bug 367596 .
Attachment #469324 - Flags: feedback?(mak77)
Attachment #469324 - Flags: feedback?(dao)
Attachment #469324 - Flags: feedback?
Attachment #479292 - Flags: feedback?(dao) → feedback?(mak77)
Attachment #469324 - Flags: feedback?
Comment on attachment 469324 [details]
Preview Screenshot

Sorry, but even if I like the changes, I can't give valid feedback for UI changes. Imo the left aligned version is much better though.
You really need feedback or ui-review from a UX team member.
Attachment #469324 - Flags: feedback?(mak77)
Attachment #479292 - Flags: feedback?(mak77) → feedback?(faaborg)
shift9999 already asked Alex for feedback, but he didn't respond at all.
I'm sorry but there is no other path than asking ux team here and I guess they're pretty much busy with FX4 stuff, eventually ping them on mozilla.dev.usability
Comment on attachment 479292 [details]
Preview Screenshot Left Aligned

Looks good
Attachment #479292 - Flags: feedback?(faaborg) → feedback+
shift9999 are you still here?
I have been extremely busy and have not had time to get the tools setup to do this. It will be another week before I could look into this again.
shift9999, did you manage to do any work on this?
shift9999, are you still here?
I am on the tail end of a three week work trip. I had setup Hg before I left so I patch will come soon.
shift9999, if you don't have time for this, please share your current css work with us to let others finish the job.
Attachment #469324 - Attachment is obsolete: true
Attachment #479292 - Attachment is obsolete: true
I have attached the uploaded source files (tip as of 07/08/28) to the bug as I have not had time to get Mercurial setup, yet alone learn how to use it properly.
Hopefully someone could take these and make a patch.

Sorry about the extreme delay, I hope to have time in the coming weeks to get everything setup so that I may properly contribute to Firefox. 

Note: I could not check look of the "graphics error" section as it is created dynamically via javascript.
Attachment #550565 - Flags: ui-review?(faaborg)
Comment on attachment 550565 [details] [diff] [review]
aboutSupport patch ver.1

generally this sounds fine, but re-request with a screenshot attached.
Attachment #550565 - Flags: ui-review?(faaborg)
There is a screenshot attached to this bug. Unless I am misunderstanding where it must be attached.
Maybe you should request a review for the screenshot?
Blocks: 1369800
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.