fix problematic usage of 'size_t' in IPC code, 'size_t' size depends on architecture

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: jaas, Assigned: jaas)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

13.36 KB, patch
cjones
: review+
Details | Diff | Splinter Review
Assignee

Description

9 years ago
Posted patch fix v1.0 (obsolete) — Splinter Review
In order to support cross-architecture out-of-process plugins we can't pass IPC messages with types that vary in size depending on architecture. 'size_t' is not the same size on every architecture and we need to fix problematic usage of it.

Much of this patch was written by Ben Turner, I wrote the shmem portion of it.
Attachment #469374 - Flags: review?(jones.chris.g)
Assignee

Updated

9 years ago
blocking2.0: --- → beta6+
Assignee

Updated

9 years ago
Blocks: 559142
Assignee

Updated

9 years ago
Attachment #469374 - Attachment is patch: true
Attachment #469374 - Attachment mime type: application/octet-stream → text/plain
Assignee

Comment 1

9 years ago
Posted patch fix v1.1Splinter Review
Linux compile fix.
Attachment #469374 - Attachment is obsolete: true
Attachment #469515 - Flags: review?(jones.chris.g)
Attachment #469374 - Flags: review?(jones.chris.g)
Comment on attachment 469515 [details] [diff] [review]
fix v1.1

We could avoid a lot of the static_casts in the pickle code, but there's definitely value in keeping parity with the old chromium impl.

Looks good, thanks!
Attachment #469515 - Flags: review?(jones.chris.g) → review+
Assignee

Comment 3

9 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/eea1c03b2d27
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.