590870 - Crash attempting to create remote XUL element [@ nsDocument::CreateElementNS ]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Try to create an element in the XUL namespace

Gecko 0.x/1.x result: [object XULElement]

Actual result: Crash

Comment 2

[Daniel C]

bp-9d5c9d39-b1e1-4345-a7eb-d6d972100826

Comment 3

[Steve]

(In reply to comment #2)
> bp-9d5c9d39-b1e1-4345-a7eb-d6d972100826

Related crash bp-271889eb-f486-4dfa-9315-c17102100826 is averted by ensuring the createElementNS method is called upon the xul document into which the element is to inserted rather than (erroneously) upon the content document.createElementNS of some recently loaded webpage.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Should fix it

Obvious fix. I'll add a testcase as well.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 470092 [details] [diff] [review]
Should fix it

r=jst :)

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Fixed friday night:

http://hg.mozilla.org/mozilla-central/rev/1fe5a5c22b0f

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Fixed friday night:

http://hg.mozilla.org/mozilla-central/rev/567c0e5bf04e

However I need to figure out a way to test this. We should probably set up a domain which doesn't support XUL.

Leaving as assigned to remind me to check in a test.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Please ignore comment 8, it relates to another bug.

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Tests patch 1. Allow XUL support on a site-by-site basis in mochitest

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Tests patch 2. Test creating XUL elements with and without xul support

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Gonna reopen this to get attention to the review requests though.

Comment 13

[(not currently active) Ted Mielczarek]

Comment on attachment 470961 [details] [diff] [review]
Tests patch 1. Allow XUL support on a site-by-site basis in mochitest

>diff --git a/build/automation.py.in b/build/automation.py.in
>--- a/build/automation.py.in
>+++ b/build/automation.py.in
>@@ -302,37 +302,38 @@ class Automation(object):
>        type TEXT,
>        permission INTEGER,
>        expireType INTEGER,
>        expireTime INTEGER)""")
> 
>     # Insert desired permissions
>     c = 0
>     for perm in permissions.keys():
>-      for host in permissions[perm]:
>+      for (host,allow) in permissions[perm]:

You don't need the parentheses here.

>     # Set up permissions database
>     locations = self.readLocations()
>     self.setupPermissionsDatabase(profileDir,
>-      {'allowXULXBL':map(lambda l: l.host, locations)});
>+      {'allowXULXBL':map(lambda l: (l.host, 'noxul' not in l.options),
>+                         locations)});

I missed this last time, but this would be better written as a list comprehension:
{'allowXULXBL':[(l.host, 'noxul' not in l.options) for l in locations]}

r=me with those changes.

Comment 14

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in to m-c

http://hg.mozilla.org/mozilla-central/rev/52f58de5bd35
http://hg.mozilla.org/mozilla-central/rev/7f98e06f680d