590992 - Flag network preference modifications in the validator

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Jorge Villalobos [:jorgev] (he/him)]

I think something along the lines of set*Pref(*'network.* should be enough to reduce the noise. I'll post a patch later today.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Patch V1. Flag network.http.*

To keep consistency with the current checks and not get too many false positives, the patch is limited to network.http.*

Comment 2

[Wil Clouser [:clouserw]]

CCing basta for the new tools

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Fixed on trunk, r73514.

Keeping this open for the new tools.

Comment 4

[Matt Basta [:basta]]

This won't make it into 5.12.3. It requires literal analysis in the traverser. I haven't even started to work on stuff like that. If it's a really high-priority feature, I can just throw a Regex test in so the code can be deployed, but to do it "right" is going to take a few weeks.

Comment 5

[Wil Clouser [:clouserw]]

If we can do grep quickly, let's do that.  Once that's done, we can kick it out

Comment 6

[Matt Basta [:basta]]

Completed. Both the code and the tests are included in 58a0cd9.

https://github.com/mattbasta/amo-validator/commit/58a0cd954649ec2ddd981b678e5b988d3b173833

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...