591081 - e10s: ExternalHelperAppChild should still make use of parts of nsExternalAppHandler

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Brian Crowder]

A lot of the code in nsExternalAppHandler is code that still needs to be executed, even after the work of doing the actual download has been forwarded back to the parent process.  By reorganizing the code in nsExternalAppHandler a bit and pumping OnStart/OnData/OnStop calls to we can reuse the code and fix a handful of bugs.

One bug in particular is that currently, you cannot issue two download requests simultaneously from the same page, because they will remain in the same loadGroup on the child process, causing the original transfer to be cancelled when the second begins.

Comment 1

[Brian Crowder]

Attachment: v1

Comment 2

[[e-mail]]

Comment on attachment 471216 [details] [diff] [review]
v1

>diff --git a/uriloader/exthandler/nsExternalHelperAppService.cpp b/uriloader/exthandler/nsExternalHelperAppService.cpp

>+    nsExternalAppHandler * handler = new nsExternalAppHandler(nsnull,

This needs to be an nsRefPtr<>. (It's bad to go passing around objects with refcount 0 -- think about what happens if the function you pass it into wraps it in an nsCOMPtr or QI's it and then lets the COMPtr go out of scope!)

r=dwitte.

Comment 3

[Brian Crowder]

Attachment: land this

Comment 4

[Josh Matthews [:jdm]]

http://hg.mozilla.org/mozilla-central/rev/a2d78881240c