596402 - Pausing download shows error

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

When you pause a download, a download error prompt is show reading:

"Downloading
 could not be saved, because the source file could not be read.
Try again later, or contact the server administrator"

The good news is, the download actually is paused and can be resumed.

Comment 1

[Wesley Johnston (:wesj)]

Crowder, this is on you... I think.

Something funny happens in nsExternalAppHandler. When the download is paused, its Cancel is called so that mCancelled = true; However, between that and when OnStopRequest is called later, mCancelled = false; and the download assumes some error has happened.

Comment 2

[Brian Crowder]

The patch in bug 591081 caused this bug by invoking nsExternalAppHandler::OnStopRequest correctly, which we didn't do before.  The patch is, I think, pretty easy and coming right up.

Comment 3

[Brian Crowder]

Attachment: only manually prompt for chrome

This whole section of code should probably simply be removed.  The code here really has no business providing a prompt in the absense of a progress listener.

Comment 4

[Brian Crowder]

Attachment: with MOZ_IPC

Need wrappers to build...

Comment 5

[[e-mail]]

Comment on attachment 475584 [details] [diff] [review]
with MOZ_IPC

r=dwitte

Comment 6

[Brian Crowder]

http://hg.mozilla.org/mozilla-central/rev/10257eea7533

Landed this a while ago, sorry for not resolving.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified:
Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b7pre)Gecko/20100922 Firefox/4.0b7pre Fennec/2.0b1pre

Mozilla/5.0 (Android; Linux armv71; rv2.0b7pre) Gecko/20100922 Firefox/4.0b7pre Fennec/2.0b1pre

For Android, don't use the context picker : bug 593408

Steps to repro :
1. go to URL : http://people.mozilla.com/~nhirata/html_tp/Docs/
2. download IMG_0092.zip
3. during download go to the control panel
4. select pause

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

litmus test case already exists : 
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=12201
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=12268
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=12163