591361 - Borders are rendered with gaps at the corners when different colors are specified for individual sides

Status: RESOLVED WORKSFORME

Description

[Chris Robinson]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b5pre) Gecko/20100827 Minefield/4.0b5pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b5pre) Gecko/20100827 Minefield/4.0b5pre

When creating a box using CSS borders a gap is rendered at the corners of the box if different colors are specified for individual sides.

Reproducible: Always

Steps to Reproduce:
1. Go to http://www.w3schools.com/css/tryit.asp?filename=trycss_border-color
2. The css examples here should show the problem.
3. Try the same page in Firefox 3.6
Actual Results:  
Borders are rendered with a break at the corner

Expected Results:  
border corners should meet.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

Cannot repro on WinXP.
To test if this is an D2D Rendering Issue, check "about:support" very bottom "Direct2D Enabled" Status.
Test against setting "mozilla.widget.render-mode" to 0 using about:config.

Comment 2

[Chris Robinson]

(In reply to comment #1)
This only shows with Direct2D enabled.

Comment 3

[Chris Robinson]

Created attachment 469903 [details]
An image that shows the gap.

Comment 4

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Looks like we lose the beveling on one end of the border there somehow.  Bas?

Comment 5

[[not reading bugmail]]

looks like a dupe of bug 590407

Comment 6

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Related, but may not be dup; there are no rounded borders here.

Comment 7

[Joe Drew (not getting mail)]

Huh, I can't reproduce this. In the latest nightlies, we have more information about your video card in about:support - Chris, can you paste that here?

Comment 8

[[not reading bugmail]]

I can reproduce it.

        Adapter Description        NVIDIA GeForce 7050 / NVIDIA nForce 610i
        Vendor ID        10de
        Device ID        07e3
        Adapter RAM        256
        Adapter Drivers        nvd3dum
        Driver Version        8.17.12.5721
        Driver Date        6-7-2010
        Direct2D Enabled        true
        DirectWrite Enabled        true

Comment 9

[[not reading bugmail]]

Nvidia 7050 is D3D9.

Comment 10

[Chris Robinson]

Adapter Description NVIDIA Quadro NVS 110M 
Vendor ID 10de
Device ID 01d7
Adapter RAM 128
Adapter Drivers nvd3dum nvwgf2um
Driver Version 7.15.11.7967
Driver Date 3-6-2009
Direct2D Enabled true
DirectWrite Enabled true

Comment 11

[Joe Drew (not getting mail)]

These are all DirectX 9 parts; we don't officially support those, so this issue can't block.

Comment 12

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Do we need to blacklist them, then?

Comment 13

[Joe Drew (not getting mail)]

No. These users have turned on D2D explicitly; blacklisting is for where it causes more pain than just bad drawing.

Comment 14

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Oh, I see.  So is the plan to default d2d off on unsupported hardware but allow users to override?

Comment 15

[Joe Drew (not getting mail)]

Right. ("Allowing" users to override really just means not disallowing them from overriding.)

Comment 16

[[not reading bugmail]]

I believe this is now fixed.

Comment 17

[[not reading bugmail]]

Created attachment 494904 [details]
Connected D2D borders

This is working for me now with the landing of bug 588271, D2D Nvidia 7050.

Comment 18

[(mostly gone) XtC4UaLL [:xtc4uall]]

Closable as WFM/Fixed by Bug 588271 then?

Comment 19

[Joe Drew (not getting mail)]

Sure.