591504 - Tab drop indicator does not appear just after the start of browser

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100827 Minefield/4.0b5pre ID:20100827040251
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100827 Minefield/4.0b5pre ID:20100827040251

Tab drop indicator does not appear just after the start of browser.

Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Drag a link on tab strip.


Actual Results:
 Tab drop indicator does not appear.

Expected Results:
 Tab drop indicator should appear.

Comment 1

[Christian Ascheberg]

The same is true for dragging tabs, not only links, so I think this is a regression.

Comment 2

[Christian Ascheberg]

works: 2010-04-19-03-mozilla-central
broken: 2010-04-20-04-mozilla-central

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #2)
> works: 2010-04-19-03-mozilla-central
> broken: 2010-04-20-04-mozilla-central

Thanks. Can you also please specify the changeset ids?

Comment 4

[Christian Ascheberg]

(In reply to comment #3)

2010-04-19-03: 85c3175de68f
2010-04-20-04: 5f229488969c

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=85c3175de68f&tochange=5f229488969c

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dao, could this in some way be related to bug 549061, which introduced the new tab style?

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #5)
> Dao, could this in some way be related to bug 549061, which introduced the new
> tab style?

I guess it could be related -- the code that landed there could have triggered it somehow.

Comment 7

[Alice0775 White]

If I add style attribute for tab-drop-indicator, the problem does not happen.

in browser\base\content\tabbrowser.xml

-       <xul:image class="tab-drop-indicator" anonid="tab-drop-indicator" collapsed="true"/>
+       <xul:image class="tab-drop-indicator" anonid="tab-drop-indicator" 
+                         collapsed="true" style="margin-top: -11px;"/>

Comment 8

[adoa.coturnix]

On my linux 4.0b11pre nightly version of Minefield I the tab-drop-indicators are only visible when above the tab-bar there is some other bar, menubar or awesomebar. With tabs on top and menubar compressed into a button the indicators won't be drawn.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Windows NT 6.1; rv:2.0b12pre) Gecko/20110209 Firefox/4.0b12pre