Closed
Bug 591706
Opened 14 years ago
Closed 14 years ago
GroupItem.add: don't compute findInsertionPoint if we don't have a dropPos
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 4.0b7
People
(Reporter: mitcho, Assigned: mitcho)
References
Details
Attachments
(1 file, 5 obsolete files)
|
8.56 KB,
patch
|
Details | Diff | Splinter Review |
If we don't have a dropPos specified, it's just going to go at the end of the list anyway. Do that directly.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #470231 -
Flags: review?(dolske)
|
||
Updated•14 years ago
|
Attachment #470231 -
Flags: feedback+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #470231 -
Flags: review?(dolske) → review?(dietrich)
|
||
Updated•14 years ago
|
Attachment #470231 -
Flags: review?(dietrich)
Attachment #470231 -
Flags: review+
Attachment #470231 -
Flags: approval2.0+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #470231 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 3•14 years ago
|
||
|
|
||
Comment 4•14 years ago
|
||
And backed out due to Moth test failures.
|
|
Assignee | |
Comment 5•14 years ago
|
||
Note that bug 591705 was the culprit for failing mochitests on jdm's checking.
However, we need a mochitest for this before we can land it.
Keywords: checkin-needed → testcase-wanted
|
|
Assignee | |
Updated•14 years ago
|
Attachment #471933 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: testcase-wanted
|
|
Assignee | |
Comment 6•14 years ago
|
||
Attachment #472500 -
Flags: review?(dietrich)
|
|
||
Comment 7•14 years ago
|
||
Comment on attachment 472500 [details] [diff] [review]
Patch with test, as well as quick mod to dragdrop test to make it more robust
r=me, thanks for adding the test!
Attachment #472500 -
Flags: review?(dietrich)
Attachment #472500 -
Flags: review+
Attachment #472500 -
Flags: approval2.0+
|
|
Assignee | |
Comment 8•14 years ago
|
||
Attachment #472500 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 9•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
|
|
||
Comment 10•14 years ago
|
||
Backed out because of Linux test failures:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283899045.1283900225.31464.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 11•14 years ago
|
||
Patch had rotted. Fixed.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #472768 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 12•14 years ago
|
||
Attachment #473276 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Comment 13•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•