GroupItem.add: don't compute findInsertionPoint if we don't have a dropPos

VERIFIED FIXED in Firefox 4.0b7

Status

defect
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: mitcho, Assigned: mitcho)

Tracking

Trunk
Firefox 4.0b7
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 5 obsolete attachments)

If we don't have a dropPos specified, it's just going to go at the end of the list anyway. Do that directly.
Posted patch Proposed (trivial) patch (obsolete) — Splinter Review
Attachment #470231 - Flags: review?(dolske)
Attachment #470231 - Flags: feedback+
Attachment #470231 - Flags: review?(dolske) → review?(dietrich)
Attachment #470231 - Flags: review?(dietrich)
Attachment #470231 - Flags: review+
Attachment #470231 - Flags: approval2.0+
Posted patch Patch for checkin (obsolete) — Splinter Review
Attachment #470231 - Attachment is obsolete: true
And backed out due to Moth test failures.
Note that bug 591705 was the culprit for failing mochitests on jdm's checking.

However, we need a mochitest for this before we can land it.
Attachment #471933 - Attachment is obsolete: true
Comment on attachment 472500 [details] [diff] [review]
Patch with test, as well as quick mod to dragdrop test to make it more robust

r=me, thanks for adding the test!
Attachment #472500 - Flags: review?(dietrich)
Attachment #472500 - Flags: review+
Attachment #472500 - Flags: approval2.0+
Posted patch Patch for checkin (obsolete) — Splinter Review
Attachment #472500 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/4e0ade1d0968
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
Backed out because of Linux test failures:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283899045.1283900225.31464.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Posted patch Patch for checkin (obsolete) — Splinter Review
Patch had rotted. Fixed.
Attachment #472768 - Attachment is obsolete: true
Attachment #473276 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/1e478b482a06
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
verified on recent nightly builds of minefield
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.