Closed Bug 591706 Opened 14 years ago Closed 14 years ago

GroupItem.add: don't compute findInsertionPoint if we don't have a dropPos

Categories

(Firefox Graveyard :: Panorama, defect)

Product:
Firefox Graveyard
Component:
Panorama
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 4.0b7

People

(Reporter: mitcho, Assigned: mitcho)

References

Details

Attachments

(1 file, 5 obsolete files)

Patch for checkin
8.56 KB, patch
Details | Diff | Splinter Review 
If we don't have a dropPos specified, it's just going to go at the end of the list anyway. Do that directly.
Attached patch Proposed (trivial) patch (obsolete) — — Splinter Review 

        Attachment #470231 -
        Flags: review?(dolske)

        Attachment #470231 -
        Flags: feedback+

        Attachment #470231 -
        Flags: review?(dolske) → review?(dietrich)

        Attachment #470231 -
        Flags: review?(dietrich)

        Attachment #470231 -
        Flags: review+

        Attachment #470231 -
        Flags: approval2.0+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch for checkin (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #470231 -
        Attachment is obsolete: true

    
    

    
  
And backed out due to Moth test failures.

    
    

    
  
Note that bug 591705 was the culprit for failing mochitests on jdm's checking.

However, we need a mochitest for this before we can land it.
Keywords: checkin-needed → testcase-wanted

        Attachment #471933 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 472500 [details] [diff] [review]
Patch with test, as well as quick mod to dragdrop test to make it more robust

r=me, thanks for adding the test!

        Attachment #472500 -
        Flags: review?(dietrich)

        Attachment #472500 -
        Flags: review+

        Attachment #472500 -
        Flags: approval2.0+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch for checkin (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #472500 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/4e0ade1d0968
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6

    
    

    
  
Backed out because of Linux test failures:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1283899045.1283900225.31464.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch for checkin (obsolete)
        — 
          — Splinter Review
      

    


  
Patch had rotted. Fixed.

        Attachment #472768 -
        Attachment is obsolete: true

    
    

    
  


  

        Attachment #473276 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/1e478b482a06
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

    
    

    
  
verified on recent nightly builds of minefield
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: