591805 - Flash object not cleared when leaving page

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Onno Witvliet]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100827 Firefox/4.0b5pre
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100827 Firefox/4.0b5pre

When leaving the above webpage, the flash object is not cleared, a white rectangle is visible on the new page

Reproducible: Always

Steps to Reproduce:
1. Open http://adblockplus.org/en/
2. Wait for the flash object to load
3. Navigate to another page, for example by clicking a link on the page
Actual Results:  
New page loads, but a white rectangle the size of the flash object is visible on top of the page content

Expected Results:  
No visible rectangle on the new page

The problem is MacOS only, the windows version, doesn't have the problem.

Regression range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=01fa971e62ee&tochange=0886ad6e6aaa

Comment 1

[Boris Zbarsky [:bzbarsky]]

Timothy, could this be you?

Comment 2

[Timothy Nikkel (:tnikkel)]

It could be. I used to see this exact issue but I do not anymore. I would have thought bug 587534 would have made this impossible.

Comment 3

[Timothy Nikkel (:tnikkel)]

Hmm, Mac OS only. Mac plugins have significant differences from other platforms. So it could be that we need something similar to bug 587534 in another place for mac. Without a mac though I can't figure this out.

Comment 4

[d.a.]

I can confirm that I see this bug, and I'm on OS X. 

The white rectangle will disappear on the forth page you visit after viewing a flash object:

1. Flash Object page
2. first page visiting - white rectangle present
3. second page - white rectangle present
4. third page - white rectangle present
5. forth page - white rectangle no longer present

The white rectangle will not return when using the back button to go back to previous pages. 

Reloading the same page multiple times has no effect, only way to make it disappear is by going 4 pages away from the flash object page.

Comment 5

[Deb Richardson [:dria] (plz NEEDINFO)]

Attachment: flash object messing up my Persona titlebar

Comment 6

[Deb Richardson [:dria] (plz NEEDINFO)]

I've seen this on several occasions today with the latest nightly, and it seems to have an impact on my Persona as well, which sort of freaked me out.  The flash object seems to mess around with the Persona in my titlebar, clearing the image so it only shows the background colour.

I'll attach a screenshot.  Also on OSX.

Comment 7

[d.a.]

Earlier today I got the Flash object to mess with the titlebar and awesomebar. The awesomebar would not show the address of the displayed page until I navigated to the 4th page after the one with the flash object.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Should be fixed on trunk by checkin for bug 592563.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

dria, Onno, can you confirm this is fixed?

Comment 10

[Timothy Nikkel (:tnikkel)]

The fix will be in tomorrow's nightly.

Comment 11

[Timothy Nikkel (:tnikkel)]

Or at least I hope it's the fix. :)

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

What fix are you talking about? I was hoping this was fixed by bug 592563

Comment 13

[Timothy Nikkel (:tnikkel)]

That's the one I'm talking about. Unless I'm making a mistake, it didn't land in time to make the 2010-09-07 nightlies, but it will be in the 2010-09-08 nightlies.

Comment 14

[d.a.]

I can confirm that this bug as well as the right click bug is fixed in the latest hourly.

Comment 15

[Onno Witvliet]

I can confirm that this bug is fixed in 2010-09-08 nightly (the 2010-09-07 nightly still had the bug)

Comment 16

[Timothy Nikkel (:tnikkel)]

Calling this fixed, if not please reopen.