591807 - Error while selecting bookmark in BM without any other window open

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Stefan [:stefanh]]

STR:

1) Get a mac, launch SeaMonkey
2) Close any open windows
3) From the main menu bar, select "Manage Bookmarks..."
4) In the BM window select a bookmark

--> an error in the js console appears, indicating code that relies on an open browser window:

Error: event is not defined
Source File:
file:///Users/Stefan/objdir-sm-trunk/mozilla/dist/SeaMonkeyDebug.app/Contents/MacOS/components/nsMicrosummaryService.js
Line: 1982

Comment 1

[Stefan [:stefanh]]

Oh, right - forgot to say that this assumes that bug 586363 is resolved, since atm the BM won't open at all if all windows are closed.

Comment 2

[Robert Kaiser]

Hmm, the microsummary service is a toolkit component. Does Firefox still have the same hiddenWindow stuff? Is this happening there as well?

Comment 3

[Stefan [:stefanh]]

Firefox has a slightly different implementation of the hiddenwindow stuff, so I'm not sure we can rely on toolkit doing the right thing here.

Comment 4

[Ian Neal]

I suppose the question is whether it does happen in Firefox, if it does then this bug or a clone should be put against firefox/toolkit. Either way I don't think we can block on this but if we get a fix we should try and take it.

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Bug 524091 removed microsummaries support, including the cited file. I guess we need to open a bug about removing all traces from our code and then investigate closing this one. Before I file such a bug, I think the Council should decide whether that's OK or the feature should be kept (in which case we would have to maintain it; just asking for "better safe than sorry").

Comment 6

[Philip Chee]

The backend was removed including the toolkit components. So the front end UI code in /suite/ doesn't work anyway.

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #6)
> The backend was removed including the toolkit components. So the front end
> UI code in /suite/ doesn't work anyway.

Yes, as I said. My questions was whether anyone intends to bring it back (to suite land) or that removal bug should be filed.

Comment 8

[Robert Kaiser]

Microsummaries are/were never really used in any way broadly and removing simplifies code, I'd suggest following that and also removing all traces of it in SeaMonkey.

Comment 9

[Philip Chee]

When I say backend I include the removal of code from the CPP widget code. It's hard to see how that can be brought into the Suite.

> Microsummaries are/were never really used in any way broadly and removing 
> simplifies code, I'd suggest following that and also removing all traces of it 
> in SeaMonkey.
Agreed.

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

Filed bug 659277 for the removal. Once that is fixed, this one can be closed.

Comment 11

[Jens Hatlak (:InvisibleSmiley)]

Stefan, please check again with the next trunk nightly, then resolve if the error is gone.

Comment 12

[Jens Hatlak (:InvisibleSmiley)]

Bah, make that "the next trunk nightly that contains the full fix for bug 659277"...

Comment 13

[Stefan [:stefanh]]

(In reply to comment #11)
> Stefan, please check again with the next trunk nightly, then resolve if the
> error is gone.

Yeah, it's gone. Resolving as fixed, since bug 659277 obviously fixed it ;-)