659277 - Remove microsummaries support from SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Bug 524091 removed microsummaries support from the platform. As per bug 591807 comment 5 and following, we should remove it from Suite code, too.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

http://mxr.mozilla.org/comm-central/search?string=microsummar&find=suite&tree=comm-central

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

For reference:

http://hg.mozilla.org/mozilla-central/rev/512f90d0dce157f6867e3c90971062b787840cd3
http://hg.mozilla.org/mozilla-central/rev/914e10b323c11cef1e9b93762d1ca5bf19bb71ee

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: comment 10]

Requesting review from Callek for the installer changes and from Neil for the rest.

Comment 4

[[e-mail]]

Comment on attachment 534902 [details] [diff] [review]
patch [Checkin: comment 10]

>-    <menuitem id="placesContext_sortBy:name"
>+   <menuitem id="placesContext_sortBy:name"
Spurious indentation glitch. sr=me with that fixed.

Comment 5

[Philip Chee]

Callek, review ping?

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 534902 [details] [diff] [review]
patch [Checkin: comment 10]

I think this is worth getting into comm-aurora (minus the l10n changes), anyone agree?

Comment 7

[Philip Chee]

> I think this is worth getting into comm-aurora (minus the l10n changes), anyone agree?
Well Bug 659862 is due to the microsummaries being removed from Firefox 6 so if Bug 524091 landed on mozilla-aurora then we better fix our side as well.

Comment 8

[Ian Neal]

Comment on attachment 534902 [details] [diff] [review]
patch [Checkin: comment 10]

a=me (as suggested without the string changes)

Comment 9

[Robert Kaiser]

(In reply to comment #7)
> if Bug 524091 landed on mozilla-aurora then we better fix our side as well.

We need to fix on our side, yes. It didn't land _on aurora_ but it landed on central before it was uplifted to aurora, and therefore it is in what is currently aurora.

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 534902 [details] [diff] [review]
patch [Checkin: comment 10]

http://hg.mozilla.org/comm-central/rev/0155789c1e3c

Comment 11

[Jens Hatlak (:InvisibleSmiley)]

When checking into comm-aurora, please mind both comment 4 and comment 8.

Comment 12

[Jens Hatlak (:InvisibleSmiley)]

Attachment: bustage fix [Checkin: comment 16]

I don't know how, but I missed to port the change to editBookmarkOverlay.xul so (at least) the New Bookmark dialog is now really broken without this fix.

I'd appreciate if I were allowed to just push this bustage fix instead of having to back out. I'd even volunteer to create a self-contained comm-aurora patch then! :-)

Comment 13

[Jens Hatlak (:InvisibleSmiley)]

Seems I have a recurring off-by-one indentation problem, bah. Fixed locally.

Comment 15

[Robert Kaiser]

Comment on attachment 537885 [details] [diff] [review]
bustage fix [Checkin: comment 16]

Given this fixes things correctly, please land on aurora in a single push with the other patch so that nothing breaks.

Comment 16

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 537885 [details] [diff] [review]
bustage fix [Checkin: comment 16]

http://hg.mozilla.org/comm-central/rev/920dffc43f30

Comment 17

[Jens Hatlak (:InvisibleSmiley)]

http://hg.mozilla.org/releases/comm-aurora/rev/1f5bbcd8bdca

Comment 18

[Tony Mechelynck [:tonymec]]

(In reply to comment #14)
> *** Bug 659862 has been marked as a duplicate of this bug. ***

Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110608 Firefox/7.0a1 SeaMonkey/2.4a1 ID:20110608003003

This problem has indeed disappeared now that the present bug is FIXED, see bug 659862 comment #9.