591808 - Rename nsSVGLength2 to SVGAnimatedLength

Status: RESOLVED DUPLICATE of bug 1540408

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

We should rename nsSVGLength2 to SVGAnimatedLength.

Comment 1

[Robert Longson [:longsonr]]

Really, why? What about all the other types nsSVGBoolean, nsSVGString etc.

Comment 2

[Jonathan Watt [:jwatt]]

Because nsSVGLength2 contains a base and animated value. Naming it SVGAnimatedLength matches the DOM name, and avoids the "why do we have an nsSVGLength2 class and an SVGLength class" question.

As for the other types like nsSVGBoolean etc., yes, I think for consistency and to make the code more approachable these should be named SVGAnimatedBool etc.

Of course there's also the unfortunate issue that dzbarksy's work to rename SVG classes wasn't completed and ended up in some cases with the internal name matching the name of the corresponding DOM interface name in the spec (e.g. SVGLength) and the DOM wrapper having "DOM" pegged onto the name (e.g. DOMSVGLength), and in other cases ended up with the DOM wrapper being given the DOM interface name in the spec. That's annoying and we should decide whether the internal classes or DOM wrapper classes should be given the name from the SVG spec. I.e.:

 * SVGFoo wrapped by SVGDOMFoo (or DOMSVGFoo or SVGFooDOM)
 * InternalSVGFoo (or something like that) wrapped by SVGFoo