Closed
Bug 591808
Opened 14 years ago
Closed 5 years ago
Rename nsSVGLength2 to SVGAnimatedLength
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
DUPLICATE
of bug 1540408
People
(Reporter: jwatt, Unassigned)
Details
We should rename nsSVGLength2 to SVGAnimatedLength.
Comment 1•14 years ago
|
||
Really, why? What about all the other types nsSVGBoolean, nsSVGString etc.
Reporter | ||
Comment 2•8 years ago
|
||
Because nsSVGLength2 contains a base and animated value. Naming it SVGAnimatedLength matches the DOM name, and avoids the "why do we have an nsSVGLength2 class and an SVGLength class" question. As for the other types like nsSVGBoolean etc., yes, I think for consistency and to make the code more approachable these should be named SVGAnimatedBool etc. Of course there's also the unfortunate issue that dzbarksy's work to rename SVG classes wasn't completed and ended up in some cases with the internal name matching the name of the corresponding DOM interface name in the spec (e.g. SVGLength) and the DOM wrapper having "DOM" pegged onto the name (e.g. DOMSVGLength), and in other cases ended up with the DOM wrapper being given the DOM interface name in the spec. That's annoying and we should decide whether the internal classes or DOM wrapper classes should be given the name from the SVG spec. I.e.: * SVGFoo wrapped by SVGDOMFoo (or DOMSVGFoo or SVGFooDOM) * InternalSVGFoo (or something like that) wrapped by SVGFoo
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•