592130 - [EB] Collections landing page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect, P2)

Description

[Justin Scott [:fligtar]]

It seems there wasn't a bug for this page: http://people.mozilla.com/~chowse/drop/amo/electric-bandwagon/v1/Collection_Landing.png

It is important as it explains what collections are. It should only appear on /collections without any sort parameter in the hopes that people only see it when they go to the main directory page.

Styling is similar to https://addons.mozilla.org/en-US/firefox/personas/
Image is https://preview.addons.mozilla.org/img/amo2009/illustrations/logo-collections-220x270.png

Comment 1

[Potch [:potch]]

http://github.com/jbalogh/zamboni/commit/981aa7f

Comment 2

[Justin Scott [:fligtar]]

Chowse is going to provide some CSS suggestions to make this look a bit more spiffy.

Comment 3

[Potch [:potch]]

does it not look like the mock?

Comment 4

[Chris Howse [:chowse]]

It does, but at larger window sizes the promo box is not tall enough. There are also a few typography nits, but nothing that's really breaking up the flow.

Here's the CSS I'd suggest to bring it a bit closer in line with the mock. Feel free to substitute em's for px's where appropriate. I'll also attach a resized and cropped version of the collections logo that fits better with this design:


.collections-landing {
	min-height: 190px;
	background-position: 95% bottom, left top;
}

.collections-landing .breadcrumbs {
	margin-bottom: 4px;
}

.collections-landing h2 {
	font-family: inherit;  /* this should be Meta eventually */
	font-size: 36px;
	font-weight: bold;
	margin-top: 0;
}

.collections-landing p {
	max-width: 450px;
	line-height: 1.25;
}

Comment 5

[Chris Howse [:chowse]]

Attachment: Recropped and Scaled Collections Logo

Comment 6

[Potch [:potch]]

http://github.com/jbalogh/zamboni/commit/e55a3e1

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

fligtar, please vet this sucker when you get a chance: https://preview.addons.mozilla.org/en-US/firefox/collections/

Comment 8

[Chris Howse [:chowse]]

Attachment: Recropped and Scaled Collections Logo

Second try, with fewer artifacts and jaggies.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

https://preview.addons.mozilla.org/en-US/firefox/collections/ looks pretty darn tootin' close, I reckon'!

Verified FIXED; if not, fligtar, please reopen.

Comment 10

[Justin Scott [:fligtar]]

I was waiting to verify for chowse's updated image to land (not sure if it did or not). But yes, looks good to me. Thanks