592338 - Provide proper feedback when trying to install a persona with a non-default theme

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

We're not going to do bug 520124 for Firefox 4 but we still need some of the work from there for notifications on installing a persona.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This is basically a vastly simpler version of the browser patch in bug 520124. It attempts to apply the theme and watches the events that come from doing that. If enabling the new theme requires a restart it displays a notification offering to do that. This is basically a simpler form of what we have in 3.6 where the add-ons manager would appear and ask the user to restart.

Also includes a fix for another test that was leaving the test theme installed.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 470999 [details] [diff] [review]
patch rev 1

Is it worth adding aAddon(.id) == newLWTheme(.id) sanity checks to the listener?

Comment 3

[Dave Townsend [:mossop]]

(In reply to comment #2)
> Comment on attachment 470999 [details] [diff] [review]
> patch rev 1
> 
> Is it worth adding aAddon(.id) == newLWTheme(.id) sanity checks to the
> listener?

aAddon and newLWTheme are slightly different objects and for reasons that escape me right now their id's differ so we can't really do this. Given that the code relies on the operation happening synchronously though we can be pretty much sure that nothing else is going to come in in the middle.

Landed: http://hg.mozilla.org/mozilla-central/rev/324ba96157fb

Comment 4

[[e-mail]]

So, lightweight themes sometimes trigger a notification bar, and sometimes a doorhanger... sigh...

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20100922 Firefox/4.0b7pre

(In reply to comment #4)
> So, lightweight themes sometimes trigger a notification bar, and sometimes a
> doorhanger... sigh...

Neil, please file a new bug for that particular issue. Thanks.