Notifications for installing lwthemes with non-default themes (port bug 592338)

RESOLVED FIXED

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Robert Kaiser, Assigned: neil@parkwaycc.co.uk)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
Bug 592338 added (doorhanger) notifications for users installing lwthemes (personas) with a non-default theme selected, we should do the same here.
(Reporter)

Comment 1

7 years ago
Created attachment 473631 [details] [diff] [review]
v1: just port the Firefox code

Here's the patch - note that this depends on both previous doorhanger patches.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #473631 - Flags: review?(neil)
(Assignee)

Comment 2

7 years ago
Comment on attachment 473631 [details] [diff] [review]
v1: just port the Firefox code

Eww, mixing popup notifications with notification bars :-(
(Reporter)

Comment 3

7 years ago
Yes, we should probably move all that to popup notifications in the end.
(Reporter)

Updated

7 years ago
Assignee: kairo → nobody
(Reporter)

Comment 4

7 years ago
Comment on attachment 473631 [details] [diff] [review]
v1: just port the Firefox code

Doesn't apply any more after core doorhanger work in bug 570004 has been dropped, so also dropping review request.

Feel free to pick up this bug and patch, I can't as long as the API for doorhangers in SeaMonkey isn't clear and I probably will have no time to do much work on anything before November anyhow.
Attachment #473631 - Flags: review?(neil)
(Assignee)

Comment 5

7 years ago
Created attachment 492305 [details] [diff] [review]
Proposed patch
[Checked in: Comment 6]

This patch just adds a notification.
Conversion to a doorhanger is covered by bug 595810.
Assignee: nobody → neil
Attachment #492305 - Flags: review?(iann_bugzilla)

Updated

7 years ago
Attachment #492305 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 6

7 years ago
Pushed changeset ecb9513d50fb to comm-central.
Version: unspecified → Trunk
Attachment #492305 - Attachment description: Proposed patch → Proposed patch [Checked in: Comment 6]

Comment 7

6 years ago
Fixed by Bug 595810

http://hg.mozilla.org/releases/comm-2.0/rev/0cd3be53dd8b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.