594776 - Notifications for installing lwthemes with non-default themes (port bug 592338)

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Robert Kaiser]

Bug 592338 added (doorhanger) notifications for users installing lwthemes (personas) with a non-default theme selected, we should do the same here.

Comment 1

[Robert Kaiser]

Attachment: v1: just port the Firefox code

Here's the patch - note that this depends on both previous doorhanger patches.

Comment 2

[[e-mail]]

Comment on attachment 473631 [details] [diff] [review]
v1: just port the Firefox code

Eww, mixing popup notifications with notification bars :-(

Comment 3

[Robert Kaiser]

Yes, we should probably move all that to popup notifications in the end.

Comment 4

[Robert Kaiser]

Comment on attachment 473631 [details] [diff] [review]
v1: just port the Firefox code

Doesn't apply any more after core doorhanger work in bug 570004 has been dropped, so also dropping review request.

Feel free to pick up this bug and patch, I can't as long as the API for doorhangers in SeaMonkey isn't clear and I probably will have no time to do much work on anything before November anyhow.

Comment 5

[[e-mail]]

Attachment: Proposed patch [Checked in: Comment 6]

This patch just adds a notification.
Conversion to a doorhanger is covered by bug 595810.

Comment 6

[[e-mail]]

Pushed changeset ecb9513d50fb to comm-central.

Comment 7

[Philip Chee]

Fixed by Bug 595810

http://hg.mozilla.org/releases/comm-2.0/rev/0cd3be53dd8b