Closed Bug 594776 Opened 14 years ago Closed 13 years ago

Notifications for installing lwthemes with non-default themes (port bug 592338)

Categories

(SeaMonkey :: Themes, defect)

Product:
SeaMonkey
Component:
Themes
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kairo, Assigned: neil)

References

Details

Attachments

(2 files)

v1: just port the Firefox code
11.60 KB, patch
Details | Diff | Splinter Review
Proposed patch [Checked in: Comment 6]
2.93 KB, patch
iannbugzilla
: review+
Details | Diff | Splinter Review 
Bug 592338 added (doorhanger) notifications for users installing lwthemes (personas) with a non-default theme selected, we should do the same here.
Here's the patch - note that this depends on both previous doorhanger patches.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #473631 - Flags: review?(neil)
Comment on attachment 473631 [details] [diff] [review]
v1: just port the Firefox code

Eww, mixing popup notifications with notification bars :-(
Yes, we should probably move all that to popup notifications in the end.
Assignee: kairo → nobody
Comment on attachment 473631 [details] [diff] [review]
v1: just port the Firefox code

Doesn't apply any more after core doorhanger work in bug 570004 has been dropped, so also dropping review request.

Feel free to pick up this bug and patch, I can't as long as the API for doorhangers in SeaMonkey isn't clear and I probably will have no time to do much work on anything before November anyhow.
Attachment #473631 - Flags: review?(neil)
This patch just adds a notification.
Conversion to a doorhanger is covered by bug 595810.
Assignee: nobody → neil
Attachment #492305 - Flags: review?(iann_bugzilla)
Attachment #492305 - Flags: review?(iann_bugzilla) → review+
Pushed changeset ecb9513d50fb to comm-central.
Version: unspecified → Trunk
Attachment #492305 - Attachment description: Proposed patch → Proposed patch [Checked in: Comment 6]
Fixed by Bug 595810

http://hg.mozilla.org/releases/comm-2.0/rev/0cd3be53dd8b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: