Closed Bug 593159 Opened 9 years ago Closed 8 years ago

Remove version.nsh dependency from installer code

Categories

(SeaMonkey :: Installer, defect, minor)

x86
Windows XP
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.10

People

(Reporter: mcsmurf, Assigned: mcsmurf)

References

Details

Attachments

(1 file, 1 obsolete file)

See Bug 593148, version.nsh code should be moved into defines.nsi.in
Attached patch Patch (obsolete) — Splinter Review
Assignee: installer → bugzilla
Status: NEW → ASSIGNED
Attachment #471640 - Flags: review?(bugzilla)
Blocks: 593148
Comment on attachment 471640 [details] [diff] [review]
Patch

>+#ifdef MOZ_OFFICIAL_BRANDING
>+VIAddVersionKey "LegalTrademarks" "${BrandShortName} is a Trademark of The Mozilla Foundation."
>+#endif

Looks good, but since we use "SeaMonkey" both in official and unofficial branding (unless someone marks a different branding dir) I want this to stay in our default builds, so please drop the ifdef.  If it becomes a problem in practice we can revisit this along with a cleaner implementation of branding on our end, imo.
Attachment #471640 - Flags: review?(bugzilla) → review+
Also for posterity, in current uses of version.nsh this is not ifdef'd, so we are not regressing anything.
WOA, did this never land?????

I didn't check if it still applies, but we should probably check and land!
Keywords: checkin-needed
(In reply to Justin Wood (:Callek) from comment #4)
> I didn't check if it still applies, but we should probably check and land!

It looks like comment 2 should be addressed first...
Keywords: checkin-needed
Whiteboard: [patchlove]
> It looks like comment 2 should be addressed first...
It can surely be fixed on check-in.
Attachment #471640 - Attachment is obsolete: true
Attachment #602177 - Flags: review+
Keywords: checkin-needed
Whiteboard: [patchlove]
http://hg.mozilla.org/comm-central/rev/e77c99d747c9

To make life easier for those checking in patches for you, please follow the instructions below in your future patches. Thanks!
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.10
Sorry, Ratty added the chechin-needed keyword, not myself ;-). I actually wanted to check it in myself.But of course it's ok that you did the check-in.
Sorry :)
You need to log in before you can comment on or make changes to this bug.