593148 - Remove version.nsh after other apps no longer use it

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

Filing now so I don't forget to do this.

Firefox no longer uses version.nsh after bug 592133 landed.

SeaMonkey, Thunderbird, and Sunbird should do the same for themselves as bug 592133 did for Firefox. After this is done, version.nsh should be removed.

Comment 1

[Robert Strong (they/them - no direct email)]

cc'ing a few people to give them a heads up and in the hope that they can help out with updating the applications.

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: SeaMonkey Patch

Comment 3

[Frank Wein [:mcsmurf]]

Oh, maybe I should file a new bug for this... :-)

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Sunbird is the only app that still references version.nsh and it is discontinued per bug 834388 so it is safe to remove version.nsh now.

Comment 5

[Brian R. Bondy [:bbondy]]

Comment on attachment 706003 [details] [diff] [review]
patch rev1

Review of attachment 706003 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Didn't test locally but looks ok.

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/dda4d19eb7d0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dda4d19eb7d0