Detail view always shows full screenshot, not thumbnail

VERIFIED FIXED in mozilla2.0b7

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Unfocused, Assigned: mossop)

Tracking

Trunk
mozilla2.0b7
Points:
---
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

(Whiteboard: [good first bug])

Attachments

(2 attachments)

Added in bug 562902, the details view is always showing the full screenshot, instead of the thumbnail.

See:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions.js#1623

It should be using screenshots[0].thumbnailURL - not screenshots[0].thumbnail
blocking2.0: --- → ?
Whiteboard: [good first bug]
But if no thumbnail is provided we would still show the full screenshot, at least given by the else path of the condition. That would break the UI too.
Yea, I made the same comment in the review of bug 562902. Dave was going to file a separate bug for that.
There hasn't been filed a follow-up yet. So should we stop displaying the full screenshot for now until a module is available which scales down larger screenshots?
(Assignee)

Comment 4

7 years ago
Going to check with AMO guys but I believe that we will always get a thumbnail for a screenshot, the only case where we wouldn't have one is for themes where we haven't downloaded the AMO data yet in which case we only have their full-sized preview.png but these are generally small enough so I suspect we will be ok just by fixing this bug for now.
blocking2.0: ? → beta6+
(Assignee)

Comment 5

7 years ago
Created attachment 471889 [details] [diff] [review]
patch rev 1

Silly mistake, easily fixed and tested
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #471889 - Flags: review?(bmcbride)
Attachment #471889 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/mozilla-central/rev/1376f2e60e6b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
VERIFIED FIXED w/ Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100917 Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
Do we have a max width set for thumbnails? Any theme from Firefox Cup has a screenshot/thumbnail which takes all the available width, i.e. https://addons.mozilla.org/en-US/firefox/addon/169343/
(Assignee)

Comment 9

7 years ago
(In reply to comment #8)
> Do we have a max width set for thumbnails? Any theme from Firefox Cup has a
> screenshot/thumbnail which takes all the available width, i.e.
> https://addons.mozilla.org/en-US/firefox/addon/169343/

You're seeing those in the add-ons manager?
Created attachment 476556 [details]
screenshot

(In reply to comment #9)
> You're seeing those in the add-ons manager?

Yes, see the attachment. New bug?
(Assignee)

Comment 11

7 years ago
(In reply to comment #10)
> Created attachment 476556 [details]
> screenshot
> 
> (In reply to comment #9)
> > You're seeing those in the add-ons manager?
> 
> Yes, see the attachment. New bug?

Yes get it filed and we'll figure it out.
Filed as bug 598670.
You need to log in before you can comment on or make changes to this bug.