Closed Bug 593217 Opened 10 years ago Closed 10 years ago

Detail view always shows full screenshot, not thumbnail

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla2.0b7
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: Unfocused, Assigned: mossop)

References

Details

(Whiteboard: [good first bug])

Attachments

(2 files)

Added in bug 562902, the details view is always showing the full screenshot, instead of the thumbnail.

See:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions.js#1623

It should be using screenshots[0].thumbnailURL - not screenshots[0].thumbnail
blocking2.0: --- → ?
Whiteboard: [good first bug]
But if no thumbnail is provided we would still show the full screenshot, at least given by the else path of the condition. That would break the UI too.
Yea, I made the same comment in the review of bug 562902. Dave was going to file a separate bug for that.
There hasn't been filed a follow-up yet. So should we stop displaying the full screenshot for now until a module is available which scales down larger screenshots?
Going to check with AMO guys but I believe that we will always get a thumbnail for a screenshot, the only case where we wouldn't have one is for themes where we haven't downloaded the AMO data yet in which case we only have their full-sized preview.png but these are generally small enough so I suspect we will be ok just by fixing this bug for now.
blocking2.0: ? → beta6+
Attached patch patch rev 1Splinter Review
Silly mistake, easily fixed and tested
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #471889 - Flags: review?(bmcbride)
Attachment #471889 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/mozilla-central/rev/1376f2e60e6b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
VERIFIED FIXED w/ Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100917 Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
Do we have a max width set for thumbnails? Any theme from Firefox Cup has a screenshot/thumbnail which takes all the available width, i.e. https://addons.mozilla.org/en-US/firefox/addon/169343/
(In reply to comment #8)
> Do we have a max width set for thumbnails? Any theme from Firefox Cup has a
> screenshot/thumbnail which takes all the available width, i.e.
> https://addons.mozilla.org/en-US/firefox/addon/169343/

You're seeing those in the add-ons manager?
Attached image screenshot
(In reply to comment #9)
> You're seeing those in the add-ons manager?

Yes, see the attachment. New bug?
(In reply to comment #10)
> Created attachment 476556 [details]
> screenshot
> 
> (In reply to comment #9)
> > You're seeing those in the add-ons manager?
> 
> Yes, see the attachment. New bug?

Yes get it filed and we'll figure it out.
You need to log in before you can comment on or make changes to this bug.