persist each group's active tab across sessions

RESOLVED FIXED in Firefox 9

Status

Firefox Graveyard
Panorama
P3
normal
RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: dietrich, Assigned: raymondlee)

Tracking

Trunk
Firefox 9

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
bug 590606 makes the active tab persist across group switching. however it doesn't persist across sessions.

to fully restore a user's session, and return them to where they left off, the active tab should be restored after a restart.

Comment 1

7 years ago
This could be the solution to bug 589665:
https://bugzilla.mozilla.org/show_bug.cgi?id=589665
Priority: -- → P2
(In reply to comment #1)
> This could be the solution to bug 589665:
> https://bugzilla.mozilla.org/show_bug.cgi?id=589665

Seems unlikely; in that bug, no Panorama information is getting saved. 

Lowering the priority on this bug; seems like a "nice to have".
Priority: P2 → P4

Comment 3

7 years ago
A nice to have. To the future it goes!
Priority: P4 → P3
Target Milestone: --- → Future
(Assignee)

Updated

6 years ago
Assignee: nobody → raymond
(Assignee)

Comment 4

6 years ago
Created attachment 560984 [details] [diff] [review]
v1
Attachment #560984 - Flags: review?(dietrich)
(Reporter)

Comment 5

6 years ago
Comment on attachment 560984 [details] [diff] [review]
v1

Review of attachment 560984 [details] [diff] [review]:
-----------------------------------------------------------------

thanks! the change generally looks fine. can you not add the property to all tabs though - instead just adding to the active tab? r=me with that change.
Attachment #560984 - Flags: review?(dietrich) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 561106 [details] [diff] [review]
Patch for checkin

 > thanks! the change generally looks fine. can you not add the property to all
> tabs though - instead just adding to the active tab? r=me with that change.

The property is added only to the active tabs now.

Pushed it to try and waiting for the results
https://tbpl.mozilla.org/?tree=Try&rev=4f78bb473bd6
Attachment #560984 - Attachment is obsolete: true
(Assignee)

Comment 7

6 years ago
> Pushed it to try and waiting for the results
> https://tbpl.mozilla.org/?tree=Try&rev=4f78bb473bd6

Passes Try!
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 8

6 years ago
Thanks for the try URL + patch with author/commit/reviewer filled out; makes pushing checkin-neededs much less work :-)

Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/50b328970b3c
Keywords: checkin-needed
Target Milestone: Future → Firefox 9
https://hg.mozilla.org/mozilla-central/rev/50b328970b3c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 10

6 years ago
keep getting
Error in saving tab value: TypeError: this.parent is null

look like it come from TabItem.save --> getStorageData

in getStorageData this.parent.getActiveTab() fails when this.parent is null
(Assignee)

Comment 11

6 years ago
(In reply to onemen.one from comment #10)
> keep getting
> Error in saving tab value: TypeError: this.parent is null
> 
> look like it come from TabItem.save --> getStorageData
> 
> in getStorageData this.parent.getActiveTab() fails when this.parent is null

Filed bug Bug 689078
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.