593294 - TM: various other defaultCompartment fixes

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Andreas Gal :gal]

Comment on attachment 471774 [details] [diff] [review]
patch

Looks good. This is all rather harmless finalization stuff and xpcshell so I will +.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 471774 [details] [diff] [review]
patch

>diff -r 8771ed0c60d8 js/src/xpconnect/shell/xpcshell.cpp
>--- a/js/src/xpconnect/shell/xpcshell.cpp	Thu Sep 02 14:52:18 2010 -0700
>+++ b/js/src/xpconnect/shell/xpcshell.cpp	Thu Sep 02 14:56:20 2010 -0700
>@@ -1963,17 +1963,17 @@ main(int argc, char **argv)
> 
>         rv = holder->GetJSObject(&glob);
>         if (NS_FAILED(rv)) {
>             NS_ASSERTION(glob == nsnull, "bad GetJSObject?");
>             return 1;
>         }
> 
>         JS_BeginRequest(cx);
>-
>+        JSAutoEnterCompartment ac(cx, glob);
>         if (!JS_DefineFunctions(cx, glob, glob_functions)) {

Doesn't this want to be an AutoCrossCompartmentCall?

Comment 4

[Andreas Gal :gal]

Can't hurt. Gregor want to change that?

Comment 5

[Gregor Wagner [:gwagner]]

Attachment: patch

I had to scope the JSAutoCrossCompartmentCall otherwise it asserts during deconstruction because there is no more context.

Comment 6

[Gregor Wagner [:gwagner]]

review ping

Comment 7

[Andreas Gal :gal]

Comment on attachment 471932 [details] [diff] [review]
patch

Undo the unrelated indentation changes please.

Comment 8

[Gregor Wagner [:gwagner]]

http://hg.mozilla.org/tracemonkey/rev/0fadb2696554

Comment 10

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/0fadb2696554