Hide the Error Console behind a preference

VERIFIED FIXED in Firefox 4.0b7

Status

()

Firefox
Menus
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Kevin Dangoor, Assigned: rc)

Tracking

(Blocks: 2 bugs, {dev-doc-complete, relnote})

Trunk
Firefox 4.0b7
dev-doc-complete, relnote
Points:
---
Dependency tree / graph
Bug Flags:
in-litmus +

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

(Whiteboard: [kd4b6])

Attachments

(2 attachments, 4 obsolete attachments)

(Reporter)

Description

7 years ago
In Firefox 4, we plan to ship the new "Web Console" tool that helps developers troubleshoot content errors, which will meet the needs of most developers.

Firefox and add-on developers rely on the Error Console to debug chrome errors (after they've set the javascript.options.showInConsole = true pref). The existence of the Error Console next to the Web Console on the menu will be confusing to typical users.

There are three parts to this change:

1. Rename the Error Console to (bikeshed painting time): Browser Console, Chrome Error Console, Chrome Console

2. create a browser.enableChromeDeveloperTools pref which defaults to false and determines whether or not the Error Console appears in the menu. Ideally, the javascript.options.showInConsole value should be migrated into this new pref (so users that previously had it turned on will see the new menu item right away).

3. Remove the javascript.options.showInConsole pref


This needs to be done in beta 6.
(Reporter)

Updated

7 years ago
blocking2.0: --- → ?
OS: Mac OS X → All
Hardware: x86 → All
(Reporter)

Updated

7 years ago
Blocks: 593957
(Assignee)

Comment 1

7 years ago
taking...
Status: NEW → ASSIGNED
(Assignee)

Comment 2

7 years ago
Created attachment 472685 [details] [diff] [review]
Error Console Pref

responds to: browser.devtools.errorconsole.enabled.

Browser must be restarted for changes to take effect.
Attachment #472685 - Flags: review?(gavin.sharp)
(Assignee)

Comment 3

7 years ago
(In reply to comment #0)
> In Firefox 4, we plan to ship the new "Web Console" tool that helps developers
> troubleshoot content errors, which will meet the needs of most developers.
> 
> Firefox and add-on developers rely on the Error Console to debug chrome errors
> (after they've set the javascript.options.showInConsole = true pref). The
> existence of the Error Console next to the Web Console on the menu will be
> confusing to typical users.
> 
> There are three parts to this change:
> 
> 1. Rename the Error Console to (bikeshed painting time): Browser Console,
> Chrome Error Console, Chrome Console

I'd recommend Browser Console, I think. The menu options should be pretty distinct then, e.g., Browser Console vs. Web Console.

> 2. create a browser.enableChromeDeveloperTools pref which defaults to false and
> determines whether or not the Error Console appears in the menu. Ideally, the
> javascript.options.showInConsole value should be migrated into this new pref
> (so users that previously had it turned on will see the new menu item right
> away).

From my patch above, I created browser.devtools.errorconsole.enabled. I guess we could migrate this to browser.devtools.browserconsole.enabled.

> 3. Remove the javascript.options.showInConsole pref

tbd.
(Assignee)

Comment 4

7 years ago
Created attachment 472699 [details] [diff] [review]
Error Console showInConsole

Removes showInConsole code and pref. No longer needed.
Attachment #472699 - Flags: review?(dtownsend)
(Assignee)

Comment 5

7 years ago
Created attachment 472701 [details] [diff] [review]
Error Console Rename

Changed Error Console to Browser Console in browser.dtd. Left references in code as-is.
Attachment #472701 - Flags: review?(gavin.sharp)
Comment on attachment 472699 [details] [diff] [review]
Error Console showInConsole

I don't think we should be removing support for this pref from all applications. Seems like you just want to make Firefox default to true.
Attachment #472699 - Flags: review?(dtownsend) → review-
(Assignee)

Comment 7

7 years ago
Created attachment 473049 [details] [diff] [review]
Error Console showInConsole->true
Attachment #472699 - Attachment is obsolete: true
Attachment #473049 - Flags: review?(dtownsend)
I think this is important to the webconsole being a successful (and unambiguous!) feature - marking this blocking beta6 so that we have a coherent story at feature freeze.
blocking2.0: ? → beta6+
Comment on attachment 473049 [details] [diff] [review]
Error Console showInConsole->true

I'm technically not a browser peer but I suspect this is fine
Attachment #473049 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 10

7 years ago
(In reply to comment #9)
> Comment on attachment 473049 [details] [diff] [review]
> Error Console showInConsole->true
> 
> I'm technically not a browser peer but I suspect this is fine

I figured since you did the first round on that piece, I'd just extend you the privilege. :)
blocking2.0: beta6+ → ?
Back you go, misplaced blocking flag
blocking2.0: ? → beta6+
Comment on attachment 472701 [details] [diff] [review]
Error Console Rename

Need to change the entity name when you make a semantic change to it.
Attachment #472701 - Flags: review?(gavin.sharp) → review-
None of the patches in this bug really make this a "browser console", so the string change seems kind of wrong - it still will be mostly filled with web content errors in the common case. Given that we're hiding it, how about we just leave the name as-is?
Comment on attachment 472685 [details] [diff] [review]
Error Console Pref

This will throw, since that pref doesn't have a default value. We should just associate both the menuitem and the key with a <command> element and just disable/enable that, too.
Attachment #472685 - Flags: review?(gavin.sharp) → review-
(Reporter)

Comment 15

7 years ago
(In reply to comment #13)
> None of the patches in this bug really make this a "browser console", so the
> string change seems kind of wrong - it still will be mostly filled with web
> content errors in the common case. Given that we're hiding it, how about we
> just leave the name as-is?

The intention is to take care of bug 593540 soon as well, which will filter out the content errors from the Browser Console. (So, the Web Console is where you go for content errors...)
(Assignee)

Comment 16

7 years ago
Well, we could get rid of that part of the bug. I kind of agree with Gavin that it's a pointless change to rename it in this case. It will still be an "Error Console".
(Reporter)

Comment 17

7 years ago
I'm not attached to Browser Console. I don't mind if "Error Console" stays that way.
(Assignee)

Comment 18

7 years ago
Created attachment 473684 [details] [diff] [review]
[checked-in] Error Console Pref + showInConsole

updated patch. Made the logic more like the inspector pref patch in bug 593536. Changed the pref to devtools.errorconsole.enabled to be more consistent.
Attachment #472685 - Attachment is obsolete: true
Attachment #472701 - Attachment is obsolete: true
Attachment #473049 - Attachment is obsolete: true
Attachment #473684 - Flags: review?(gavin.sharp)
Comment on attachment 473684 [details] [diff] [review]
[checked-in] Error Console Pref + showInConsole

same comment about .hidden/.disabled. Should probably get explicit ui-review on both of these as well.
Attachment #473684 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 20

7 years ago
Comment on attachment 473684 [details] [diff] [review]
[checked-in] Error Console Pref + showInConsole

http://hg.mozilla.org/mozilla-central/rev/2aaeb42e51a6
Attachment #473684 - Attachment description: Error Console Pref + showInConsole → [checked-in] Error Console Pref + showInConsole
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Depends on: 595096

Comment 21

7 years ago
Verified fixed using hourly build Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100910 Firefox/4.0b6pre from cset cca361001fda

The error console is hidden tools menu.  Flipping the pref to true and then restarting Firefox shows the menu entry.
Assignee: rcampbell → nobody
Status: RESOLVED → VERIFIED
Component: General → Menus
QA Contact: general → menus
Target Milestone: --- → Firefox 4.0b6
The keyboard shortcut doesn't actually get enabled. Please back out or fix quickly.
Assignee: nobody → rcampbell
Severity: blocker → normal
Status: VERIFIED → RESOLVED
Last Resolved: 7 years ago7 years ago
(Assignee)

Updated

7 years ago
Keywords: dev-doc-needed
(Assignee)

Comment 23

7 years ago
will investigate...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 24

7 years ago
I expect it has to do with setting .disabled = false instead of removing the attribute. I saw this with the inspector as well.
(Assignee)

Comment 25

7 years ago
Created attachment 474054 [details] [diff] [review]
[checked-in] Error Console Key

fix for key enablement
Attachment #474054 - Flags: review?(dietrich)

Updated

7 years ago
Attachment #474054 - Flags: review?(dietrich) → review+
(Assignee)

Comment 26

7 years ago
Comment on attachment 474054 [details] [diff] [review]
[checked-in] Error Console Key

http://hg.mozilla.org/mozilla-central/rev/5c0a3f26e0ef
Attachment #474054 - Attachment description: Error Console Key → [checked-in] Error Console Key
(Assignee)

Updated

7 years ago
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
Flags: in-litmus?
(Assignee)

Updated

7 years ago
Keywords: relnote
I updated the Menu Litmus test case to reflect this change and disabled the other test cases related to Error Console.
Flags: in-litmus? → in-litmus+
Verified with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b6pre) Gecko/20100911 Firefox/4.0b6pre
Status: RESOLVED → VERIFIED
Version: unspecified → Trunk
This got documented when robcee's blog post went up a couple days ago.
Keywords: dev-doc-needed → dev-doc-complete

Updated

7 years ago
Blocks: 596249

Updated

7 years ago
No longer depends on: 595096
Blocks: 596800

Updated

7 years ago
Blocks: 597842
Blocks: 601201

Updated

7 years ago
No longer blocks: 601201
Depends on: 601201
You need to log in before you can comment on or make changes to this bug.