Set value per tab back for TabHandlers.onUnmatched() in search.js

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: raymondlee, Assigned: aza)

Tracking

Details

(Whiteboard: [qa-])

(Reporter)

Description

8 years ago
>+  onUnmatch: function(tab, index){
>+    // TODO: Set back as value per tab.
>+    tab.setZ(500);
>+    tab.removeClass("notMainMatch");
(Reporter)

Comment 1

8 years ago
Comment from Ian
* By setting the z of a TabItem (on match/unmatch) to an absolute value, we're
probably setting ourselves up for some z order issues; drag increments z order,
so eventually things may get higher than the absolute value. If nothing else,
should set the TabItem's z back to where it started, rather than just "500".
(Reporter)

Updated

8 years ago
Depends on: 592045

Updated

8 years ago
Assignee: nobody → seanedunn
(Assignee)

Updated

8 years ago
Depends on: 595236
(Assignee)

Updated

8 years ago
Assignee: seanedunn → aza
Note that this will be fixed by the patch bug 595236.
Priority: -- → P3
(Assignee)

Comment 3

8 years ago
This was fixed, as Ian stated, in bug 595236.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.