Closed Bug 593904 Opened 9 years ago Closed 9 years ago

Add special chars check for beforeSearchKeyHandler() in the search.js

Categories

(Firefox Graveyard :: Panorama, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 4.0b10

People

(Reporter: raymondlee, Assigned: masayuki)

References

Details

(Whiteboard: [code cleanup])

+    // Only match reasonable text-like characters for quick search.
+    var key = String.fromCharCode(event.which);
+    // TODO: Also include funky chars
+    if (!key.match(/[A-Z0-9]/) || event.altKey || event.ctrlKey || event.metaKey) 
+     return;
Depends on: 592045
Priority: -- → P4
Hardware: x86 → All
Whiteboard: [code cleanup]
Target Milestone: --- → Future
this will be fixed by bug 610821.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Version: unspecified → Trunk
fixed by bug 610821.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: Future → Firefox 4.0b10
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.