594009 - Fix tabcandy-central leaks

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect)

Description

[(no longer active)]

I have pushed tabcandy-central to the try server, and I noticed that it's producing leaks on every test which opens the browser.  I bisected the tabcandy-central specific changesets to find the culprit, and this changeset is at least one cause of the leaks:

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/12c394eb7eca

As far as I can tell, the window objects stored in the arrays added in that changeset are never cleared.  Ian, maybe we should add this to the cleanup code you wrote before tabcandy landed on mozilla-central?

Comment 1

[Ian Gilman [:iangilman]]

Yes, it looks like it! Thank you for tracking it down. 

Since we're moth-balling tabcandy-central until after ff4, I'll keep this bug and have it block bug 578512.

Comment 2

[(no longer active)]

(In reply to comment #1)
> Since we're moth-balling tabcandy-central until after ff4, I'll keep this bug
> and have it block bug 578512.

Makes sense.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

We'll use tabcandy-central as an archive, only.