594131 - bookmarks opened from app tab should open with focus even if browser.tabs.loadBookmarksInBackground=TRUE

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[eyal gruss]

following Bug 579872, when current tab is an app tab, bookmarks will open in a new tab. if browser.tabs.loadBookmarksInBackground=TRUE, the bookmark will open in the background. this preference is usually relevant for middle clicks.
however, when i LEFT click an item, i always expect it to open with focus.

Comment 1

[Sindre Dammann]

Attachment: patch + test

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 474596 [details] [diff] [review]
patch + test

>+function test() {
>+  let newTab = gBrowser.addTab("http://example.com");
>+  waitForExplicitFinish();
>+  newTab.linkedBrowser.addEventListener("load", mainPart, true);
>+  
>+  Services.prefs.setBoolPref("browser.tabs.loadBookmarksInBackground", true);
>+  
>+  function mainPart() {
>+    gBrowser.pinTab(newTab);
>+    gBrowser.selectedTab = newTab;
>+    
>+    openUILinkIn("http://example.org/", "current");
>+    isnot(gBrowser.selectedTab, newTab, "shouldn't load in background");
>+    
>+    Services.prefs.setBoolPref("browser.tabs.loadBookmarksInBackground", false);

if (...prefHasUserValue(...))
  ...clearUserPref(...);

Comment 3

[Sindre Dammann]

Attachment: patch + test v2

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

This should go with beta7.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/4de37c4f3fab

Thanks Sindre!