"move to group" should not be an option on the right-click menu for app tabs

VERIFIED FIXED

Status

Firefox Graveyard
Panorama
P2
normal
VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: iangilman, Assigned: raymondlee)

Tracking

unspecified
Dependency tree / graph
Bug Flags:
in-litmus +

Details

(Whiteboard: [on-panorama-central][b8])

Attachments

(1 attachment, 5 obsolete attachments)

(Reporter)

Description

7 years ago
App tabs are available in all groups, so there's no way to move them into a group.
Priority: -- → P2
Whiteboard: [good first bug]
(Assignee)

Updated

7 years ago
Assignee: nobody → raymond
(Assignee)

Comment 1

7 years ago
Created attachment 476195 [details] [diff] [review]
v1
Attachment #476195 - Flags: feedback?(ian)
(Assignee)

Comment 2

7 years ago
Passed try
(Reporter)

Comment 3

7 years ago
Comment on attachment 476195 [details] [diff] [review]
v1

+  popup(origTab);
+  ok(!document.getElementById("context_tabViewMenu").hidden, 
+     "The tab view menu is hidden for normal tab");

This should say "is not hidden" rather than "is hidden".

f+ with that
Attachment #476195 - Flags: feedback?(ian) → feedback+
(Assignee)

Comment 4

7 years ago
Created attachment 476473 [details] [diff] [review]
v1

f+=ian
Attachment #476195 - Attachment is obsolete: true
Attachment #476473 - Flags: review?(dietrich)
(Assignee)

Updated

7 years ago
Attachment #476473 - Attachment is patch: true
Attachment #476473 - Attachment mime type: application/octet-stream → text/plain
According to bug 587990 comment 66, this fix also repairs a case of tab orphaning, so we should make this bug block.
Blocks: 587990
blocking2.0: --- → betaN+
Comment on attachment 476473 [details] [diff] [review]
v1

Unless it's changed, the approach we've taken for a long time in scenarios like this is to disable the menu item instead of hiding it. This 1) is less confusing that UI bits just disappearing and 2) gives a visual cue that might help the user intuit why an option is not available.
Attachment #476473 - Flags: review?(dietrich) → review-
(Assignee)

Comment 7

7 years ago
Created attachment 477088 [details] [diff] [review]
v1

Changed from hidden to disabled for that menu item for app tabs.
Attachment #476473 - Attachment is obsolete: true
Attachment #477088 - Flags: feedback?(ian)
(Reporter)

Comment 8

7 years ago
Comment on attachment 477088 [details] [diff] [review]
v1

+  ok(!document.getElementById("context_tabViewMenu").disabled, 
+     "The tab view menu is visible for normal tab");
+
+  popup(pinnedTab);
+  ok(document.getElementById("context_tabViewMenu").disabled, 
+     "The tab view menu is hidden for pinned tab");

These strings should say disabled/enabled rather than hidden/visible. 

Otherwise looks good.
Attachment #477088 - Flags: feedback?(ian) → feedback+
(Assignee)

Comment 9

7 years ago
Created attachment 477355 [details] [diff] [review]
v1

f+=ian
Attachment #477088 - Attachment is obsolete: true
Attachment #477355 - Flags: review?(dietrich)
(Assignee)

Updated

7 years ago
Blocks: 597043
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
Attachment #477355 - Flags: review?(dietrich) → review+
(Assignee)

Updated

7 years ago
Attachment #477355 - Flags: approval2.0?
Comment on attachment 477355 [details] [diff] [review]
v1

blockers don't need approval.
Attachment #477355 - Flags: approval2.0?
Keywords: checkin-needed
(Assignee)

Comment 11

7 years ago
Created attachment 477442 [details] [diff] [review]
Patch for check-in
Attachment #477355 - Attachment is obsolete: true
(Assignee)

Comment 12

7 years ago
Created attachment 477443 [details] [diff] [review]
Patch for check-in
Attachment #477442 - Attachment is obsolete: true
(Reporter)

Comment 13

7 years ago
Pushed to panorama-central: 

http://hg.mozilla.org/users/ian_iangilman.com/panorama-central/rev/84d68aaf1485

I'm removing the "checkin-needed" keyword and adding "[on-panorama-central]" in the whiteboard; the plan is to merge panorama-central directly to mozilla-central once the tree opens again.
Keywords: checkin-needed
Whiteboard: [good first bug] → [on-panorama-central]
(Assignee)

Updated

7 years ago
Whiteboard: [on-panorama-central] → [on-panorama-central][b8]
Flags: in-litmus?
(Reporter)

Comment 14

7 years ago
Landed on mozilla-central:

http://hg.mozilla.org/mozilla-central/rev/84d68aaf1485
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
verified with recent nightly build of minefield
Status: RESOLVED → VERIFIED
https://litmus.mozilla.org/show_test.cgi?id=13740 added to Litmus.
Flags: in-litmus? → in-litmus+
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.