594243 - nsMapiHook::PopulateCompFieldsForSendDocs should create unique temporary file for attachments.

Status: NEW

(MailNews Core :: Simple MAPI, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

nsMapiHook::PopulateCompFieldsForSendDocs should create unique temporary file for attachments as well as nsMapiHook::HandleAttachments.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix

Comment 2

[Hiroyuki Ikezoe (:hiro)]

The patch depends on fix for bug 594239.

Comment 5

[David :Bienvenu]

Comment on attachment 472909 [details] [diff] [review]
Fix

thx for the patch. I'll try it out, but in the meantime, a few comments. I know you're just moving/copying code, but we should take the opportunity to fix it:

space after // please.
+  //Temp Directory

+  nsCOMPtr <nsIFile> pTempFileDir;

current style is no space between nsCOMPtr and < on this or any of the other lines.

can you use NS_ENSURE_SUCCESS(rv, rv); here:

+      rv = pTempDir->Create(nsIFile::DIRECTORY_TYPE, 0777) ;
+      if (NS_FAILED(rv)) return rv ;

and same here since I don't think you need to check pTempFile, if rv is success.;
+  rv = pTempDir->Clone(getter_AddRefs(pTempFile));
+  if (NS_FAILED(rv) || !pTempFile)
+    return rv;

Comment 6

[David :Bienvenu]

Comment on attachment 472909 [details] [diff] [review]
Fix

this doesn't compile because nsMapiHook::CreateUniqueTempFile isn't defined in the header file.