Closed Bug 594433 Opened 11 years ago Closed 10 years ago
Ensure the matched tab isn't over the search box in the Panorama UI
No description provided.
Assigning to Aza for ux/design opinion.
Assignee: nobody → aza
Priority: -- → P4
Not sure why this is assigned to me as I wrote the bug ;) The right solution is that the search box floats over all.
Priority: P4 → P2
Target Milestone: --- → Firefox 4.0
Sean, take a look at bug 599484 for some extra info on what (I think) might be happening.
Solution was to make the shaded area of the search be a different DIV (#searchshade), at the same level as the tabs and #search DIV. Since CSS follows stacking context rules, you can't place an element between two other elements, if those two elements are in a separate stacking context, and all elements are absolutely positioned with a z-index set. Also took out an ad-hoc z-index setting that wasn't doing anything, and set #search to let mouse clicks pass through it.
Comment on attachment 482755 [details] [diff] [review] v1 Lovely!
Comment on attachment 482755 [details] [diff] [review] v1 Switching review to dolske, as dietrich says he's not reviewing non-blockers for the time being.
Attachment #482755 - Flags: review?(dietrich) → review?(dolske)
Attachment #482755 - Flags: review?(dolske) → review+
Comment on attachment 482755 [details] [diff] [review] v1 Sean, please update for check-in. Also, does this patch need to go through try?
Pushed to try: http://hg.mozilla.org/try/rev/d5b513808a08
Comment on attachment 489820 [details] [diff] [review] v2 Sorry, jumped the gun; didn't yet have approval.
Attachment #489820 - Flags: approval2.0?
Comment on attachment 489820 [details] [diff] [review] v2 a=beltzner, wondering if this should actually block
Attachment #489820 - Flags: approval2.0? → approval2.0+
Sean, please unrot this patch. Also, rather than "a-2.0+f=ian" in the commit message, it should be "a=blocking" (I don't have authority to approve or block).
Attachment #489820 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 4.0 → Firefox 4.0b8
Verified in recent nightly minefield build
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.