Closed
Bug 594433
Opened 15 years ago
Closed 15 years ago
Ensure the matched tab isn't over the search box in the Panorama UI
Categories
(Firefox Graveyard :: Panorama, defect, P2)
Firefox Graveyard
Panorama
Tracking
(blocking2.0 final+)
VERIFIED
FIXED
Firefox 4.0b8
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: raymondlee, Assigned: seanedunn)
References
Details
(Whiteboard: [visual])
Attachments
(1 file, 2 obsolete files)
|
8.19 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
||
Comment 1•15 years ago
|
||
Assigning to Aza for ux/design opinion.
Assignee: nobody → aza
Priority: -- → P4
|
|
||
Comment 2•15 years ago
|
||
Not sure why this is assigned to me as I wrote the bug ;)
The right solution is that the search box floats over all.
Priority: P4 → P2
Whiteboard: [visual]
Target Milestone: --- → Firefox 4.0
|
||
Updated•15 years ago
|
Assignee: aza → seanedunn
|
|
||
Comment 4•15 years ago
|
||
Sean, take a look at bug 599484 for some extra info on what (I think) might be happening.
Solution was to make the shaded area of the search be a different DIV (#searchshade), at the same level as the tabs and #search DIV. Since CSS follows stacking context rules, you can't place an element between two other elements, if those two elements are in a separate stacking context, and all elements are absolutely positioned with a z-index set.
Also took out an ad-hoc z-index setting that wasn't doing anything, and set #search to let mouse clicks pass through it.
Attachment #482755 -
Flags: feedback?(ian)
|
|
||
Comment 6•15 years ago
|
||
Comment on attachment 482755 [details] [diff] [review]
v1
Lovely!
Attachment #482755 -
Flags: review?(dietrich)
Attachment #482755 -
Flags: feedback?(ian)
Attachment #482755 -
Flags: feedback+
|
|
||
Comment 7•15 years ago
|
||
Comment on attachment 482755 [details] [diff] [review]
v1
Switching review to dolske, as dietrich says he's not reviewing non-blockers for the time being.
Attachment #482755 -
Flags: review?(dietrich) → review?(dolske)
|
|
Reporter | |
Updated•15 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•15 years ago
|
Attachment #482755 -
Flags: review?(dolske) → review+
|
|
||
Comment 8•15 years ago
|
||
Comment on attachment 482755 [details] [diff] [review]
v1
Sean, please update for check-in. Also, does this patch need to go through try?
Attachment #482755 -
Flags: approval2.0?
Pushed to try: http://hg.mozilla.org/try/rev/d5b513808a08
Attachment #482755 -
Attachment is obsolete: true
Attachment #482755 -
Flags: approval2.0?
|
|
Assignee | |
Comment 10•15 years ago
|
||
Try passed.
|
|
||
Comment 11•15 years ago
|
||
Comment on attachment 489820 [details] [diff] [review]
v2
Sorry, jumped the gun; didn't yet have approval.
Attachment #489820 -
Flags: approval2.0?
|
||
Comment 12•15 years ago
|
||
Comment on attachment 489820 [details] [diff] [review]
v2
a=beltzner, wondering if this should actually block
Attachment #489820 -
Flags: approval2.0? → approval2.0+
|
|
||
Updated•15 years ago
|
blocking2.0: --- → final+
|
|
||
Comment 13•15 years ago
|
||
Sean, please unrot this patch. Also, rather than "a-2.0+f=ian" in the commit message, it should be "a=blocking" (I don't have authority to approve or block).
Keywords: checkin-needed
|
||
Comment 15•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Firefox 4.0 → Firefox 4.0b8
|
||
Updated•10 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•