If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Get rid of more "secret phrase" occurrences

VERIFIED FIXED

Status

Cloud Services
Firefox Sync: UI
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [strings])

Attachments

(1 attachment, 1 obsolete attachment)

There are a few more occurrences of "secret phrase" in the strings.
Created attachment 473194 [details] [diff] [review]
v1

I don't know how I missed these before. This should get all of them.
Assignee: nobody → philipp
Attachment #473194 - Flags: review?(mconnor)
how about the phrasing [sic!] of 

"secured by this phrase" in

./browser/syncGenericChange.properties:change.synckey.warningText = Note: Changing this will erase all data stored on the Sync server and upload new data secured by this phrase. Your other devices will not sync until the new Sync Key is entered for that device.


shouldn't it be "new data secured by your __Sync key__."
(In reply to comment #2)
> shouldn't it be "new data secured by your __Sync key__."

Good catch.
Created attachment 473199 [details] [diff] [review]
v2
Attachment #473194 - Attachment is obsolete: true
Attachment #473199 - Flags: review?(mconnor)
Attachment #473194 - Flags: review?(mconnor)

Updated

7 years ago
Attachment #473199 - Flags: review?(mconnor) → review+
http://hg.mozilla.org/services/fx-sync/rev/1a99ff2796ba
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Blocks: 594577
(Assignee)

Updated

7 years ago
Blocks: 594506
verified with recent nightly minefield builds
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.