Closed
Bug 594520
Opened 14 years ago
Closed 14 years ago
Get rid of more "secret phrase" occurrences
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
People
(Reporter: philikon, Assigned: philikon)
References
Details
(Whiteboard: [strings])
Attachments
(1 file, 1 obsolete file)
|
4.28 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
There are a few more occurrences of "secret phrase" in the strings.
|
Assignee | |
Comment 1•14 years ago
|
||
I don't know how I missed these before. This should get all of them.
Assignee: nobody → philipp
Attachment #473194 -
Flags: review?(mconnor)
|
||
Comment 2•14 years ago
|
||
how about the phrasing [sic!] of "secured by this phrase" in ./browser/syncGenericChange.properties:change.synckey.warningText = Note: Changing this will erase all data stored on the Sync server and upload new data secured by this phrase. Your other devices will not sync until the new Sync Key is entered for that device. shouldn't it be "new data secured by your __Sync key__."
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #2) > shouldn't it be "new data secured by your __Sync key__." Good catch.
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #473194 -
Attachment is obsolete: true
Attachment #473199 -
Flags: review?(mconnor)
Attachment #473194 -
Flags: review?(mconnor)
|
||
Updated•14 years ago
|
Attachment #473199 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
http://hg.mozilla.org/services/fx-sync/rev/1a99ff2796ba
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•