Closed Bug 594730 Opened 14 years ago Closed 14 years ago

Make the meta prescan pay attention to http-equiv

Categories

(Core :: DOM: HTML Parser, defect, P2)

Product:
Core
Component:
DOM: HTML Parser
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(1 file, 1 obsolete file)

Pay attention to http-equiv; make late charset switch work right when the precan and the tree builder disagree, v2
61.35 KB, patch
sicking
: review+
Details | Diff | Splinter Review
The HTML5 has at some point changed to require the meta prescan to pay attention to the http-equiv attribute. Need to adjust the implementation accordingly.
Priority: -- → P3
Per discussion with jst, nominating all HTML5 parsing spec change bugs as blockers. The benefit of this particular change would be not accidentally paying attention to <meta http-equiv="Not-Content-Type" content="charset=utf-8"> or <meta name="whatever" content="charset=utf-8">. This is mainly a security feature against an attacker being able to change the interpretation of the bytes of the page by getting user-provided metadata that contains charset=foo into metadata.
Oops forgot to actually set the request flag.
blocking2.0: --- → ?
Blocking on this spec compliance change.
blocking2.0: ? → betaN+
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Priority: P3 → P2
Comment on attachment 494681 [details] [diff] [review] Pay attention to http-equiv; make late charset switch work right when the precan and the tree builder disagree, v2 rs=me
Attachment #494681 - Flags: review?(jonas) → review+
http://hg.mozilla.org/mozilla-central/rev/16847ac492b3
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Depends on: 733730
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: