594730 - Make the meta prescan pay attention to http-equiv

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P2)

Description

[Henri Sivonen (:hsivonen)]

The HTML5 has at some point changed to require the meta prescan to pay attention to the http-equiv attribute. Need to adjust the implementation accordingly.

Comment 1

[Henri Sivonen (:hsivonen)]

It seems the spec bug was http://www.w3.org/Bugs/Public/show_bug.cgi?id=9225

Comment 2

[Henri Sivonen (:hsivonen)]

Per discussion with jst, nominating all HTML5 parsing spec change bugs as blockers.

The benefit of this particular change would be not accidentally paying attention to <meta http-equiv="Not-Content-Type" content="charset=utf-8"> or <meta name="whatever" content="charset=utf-8">.

This is mainly a security feature against an attacker being able to change the interpretation of the bytes of the page by getting user-provided metadata that contains charset=foo into metadata.

Comment 3

[Henri Sivonen (:hsivonen)]

Oops forgot to actually set the request flag.

Comment 4

[Johnny Stenback (:jst)]

Blocking on this spec compliance change.

Comment 5

[Henri Sivonen (:hsivonen)]

Attachment: Pay attention to http-equiv; make late charset switch work right when the precan and the tree builder disagree

Comment 6

[Henri Sivonen (:hsivonen)]

The patch assumes fixes for these spec bugs:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11428
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11426
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11411
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11412
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11414

Comment 7

[Henri Sivonen (:hsivonen)]

Attachment: Pay attention to http-equiv; make late charset switch work right when the precan and the tree builder disagree, v2

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 494681 [details] [diff] [review]
Pay attention to http-equiv; make late charset switch work right when the precan and the tree builder disagree, v2

rs=me

Comment 9

[Henri Sivonen (:hsivonen)]

http://hg.mozilla.org/mozilla-central/rev/16847ac492b3