Closed Bug 594803 Opened 9 years ago Closed 9 years ago

Search symbol indicator icon in Panorama disappears when pressed

Categories

(Firefox Graveyard :: Panorama, defect, P3)

x86
Windows 7
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 4.0b7

People

(Reporter: aaronmt, Assigned: raymondlee)

References

Details

(Keywords: ux-userfeedback)

Attachments

(2 files, 1 obsolete file)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b6pre) Gecko/20100909 Firefox/4.0b6pre

This isn't really consistent with the UI one would expect in Firefox.
Attached image Screenshot
I believe this is the design. Assigning it to Aza.
Assignee: nobody → aza
OS: Mac OS X → Windows 7
It was an idea I was playing around with; animating the icon over to the search field. After using it for a while, the "feature" should go away.
Assignee: aza → raymond
(In reply to comment #3)
> It was an idea I was playing around with; animating the icon over to the search
> field. After using it for a while, the "feature" should go away.

Does it mean the the search symbol indicator icon should remain when user enters into the search mode?
Yes it should. Sorry about that. I think all we have to do is remove a couple lines of code.
Attached patch v1 (obsolete) — Splinter Review
Attachment #475420 - Flags: feedback?(ian)
Comment on attachment 475420 [details] [diff] [review]
v1

Looks good to me. I don't think this is the kind of change that needs a test.
Attachment #475420 - Flags: review?(dietrich)
Attachment #475420 - Flags: feedback?(ian)
Attachment #475420 - Flags: feedback+
Priority: -- → P3
Blocks: 597043
Attachment #475420 - Flags: review?(dietrich)
Attachment #475420 - Flags: review+
Attachment #475420 - Flags: approval2.0+
Attachment #475420 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/3ab55f85da6e
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b7
verified with recent builds of minefield
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.