594803 - Search symbol indicator icon in Panorama disappears when pressed

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b6pre) Gecko/20100909 Firefox/4.0b6pre

This isn't really consistent with the UI one would expect in Firefox.

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Screenshot

Comment 2

[Raymond Lee [:raymondlee]]

I believe this is the design. Assigning it to Aza.

Comment 3

[Aza Raskin [:aza]]

It was an idea I was playing around with; animating the icon over to the search field. After using it for a while, the "feature" should go away.

Comment 4

[Raymond Lee [:raymondlee]]

(In reply to comment #3)
> It was an idea I was playing around with; animating the icon over to the search
> field. After using it for a while, the "feature" should go away.

Does it mean the the search symbol indicator icon should remain when user enters into the search mode?

Comment 5

[Aza Raskin [:aza]]

Yes it should. Sorry about that. I think all we have to do is remove a couple lines of code.

Comment 6

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 7

[Ian Gilman [:iangilman]]

Comment on attachment 475420 [details] [diff] [review]
v1

Looks good to me. I don't think this is the kind of change that needs a test.

Comment 8

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in

Comment 9

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/3ab55f85da6e

Comment 10

[Tracy Walker [:tracy]]

verified with recent builds of minefield