Closed Bug 594863 Opened 12 years ago Closed 12 years ago

Encapsulate code in the GroupItems.removeHiddenGroups inside groupItem

Categories

(Firefox Graveyard :: Panorama, defect, P4)

Product:
Firefox Graveyard
Component:
Panorama
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Future

People

(Reporter: raymondlee, Assigned: raymondlee)

References

Details

>+    this.groupItems.forEach(function(groupItem) {
>+      if (groupItem.canUndo) {
>+        let toClose = groupItem._children.concat();
>+        toClose.forEach(function(child) {
>+          child.close();
>+        });

This should be encapsulated inside the groupItem.
Depends on: 587341
Priority: -- → P4
Hardware: x86 → All
Target Milestone: --- → Future
This would also be addressed when the patch in bug 599626
Depends on: 599626
No longer depends on: 587341
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Bug 599626 has landed, so this is fixed now.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.