GfxInfo blocklist needs to be used by D3D, WebGL, OpenGL

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: vlad, Assigned: bjacob)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

Attachments

(3 attachments, 1 obsolete attachment)

The GfxInfo driver blocklist needs to be checked before we create a D3D/OpenGL layer manager or a WebGL context.  Right now it's only checked in one spot for creating a D2D context.
blocking2.0: --- → betaN+
(Assignee)

Updated

8 years ago
Assignee: nobody → bjacob
(Assignee)

Comment 1

8 years ago
Created attachment 476025 [details] [diff] [review]
Part 1: OpenGL layers
Attachment #476025 - Flags: review?(vladimir)
Comment on attachment 476025 [details] [diff] [review]
Part 1: OpenGL layers

seems like we should do something with the not-recommended return here as well, but fine for a first start.
Attachment #476025 - Flags: review?(vladimir) → review+
(Assignee)

Comment 3

8 years ago
Created attachment 476055 [details] [diff] [review]
Part 2: Direct3D 9
Attachment #476055 - Flags: review?(vladimir)
(Assignee)

Comment 4

8 years ago
Created attachment 476056 [details] [diff] [review]
Part 3: WebGL
Attachment #476056 - Flags: review?(vladimir)
(Assignee)

Comment 5

8 years ago
argh! no! sorry! typos! gimme a minute
Attachment #476055 - Flags: review?(vladimir) → review+
Comment on attachment 476056 [details] [diff] [review]
Part 3: WebGL

Wrong comment and feature selector for WebGL :-)
(Assignee)

Updated

8 years ago
Attachment #476066 - Attachment description: P → Part 3: WebGL
Attachment #476066 - Attachment is patch: true
Attachment #476066 - Attachment mime type: application/octet-stream → text/plain
Attachment #476066 - Flags: review?(vladimir)
(Assignee)

Updated

8 years ago
Attachment #476056 - Attachment is obsolete: true
Attachment #476056 - Flags: review?(vladimir)
(Assignee)

Comment 8

8 years ago
Yes. Can you review the new patch? I am unsure as to if it safe to say that EGL == ANGLE. Otherwise I don't know how to honor the ANGLE blocklist.
Attachment #476066 - Flags: review?(vladimir) → review+
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
For some reason this breaks my builds because LayerManagerD3D9.cpp uses do_GetService without explicitly including nsServiceManagerUtils.h (I don't know what normally includes it, might be the D2D surface perhaps.)

Updated

7 years ago
Depends on: 620669
You need to log in before you can comment on or make changes to this bug.