594874 - GfxInfo blocklist needs to be used by D3D, WebGL, OpenGL

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The GfxInfo driver blocklist needs to be checked before we create a D3D/OpenGL layer manager or a WebGL context.  Right now it's only checked in one spot for creating a D2D context.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Part 1: OpenGL layers

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 476025 [details] [diff] [review]
Part 1: OpenGL layers

seems like we should do something with the not-recommended return here as well, but fine for a first start.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Part 2: Direct3D 9

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Part 3: WebGL

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

argh! no! sorry! typos! gimme a minute

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 476056 [details] [diff] [review]
Part 3: WebGL

Wrong comment and feature selector for WebGL :-)

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Part 3: WebGL

Comment 8

[Benoit Jacob [:bjacob] (mostly away)]

Yes. Can you review the new patch? I am unsure as to if it safe to say that EGL == ANGLE. Otherwise I don't know how to honor the ANGLE blocklist.

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/mozilla-central/rev/0efaead12cc8
http://hg.mozilla.org/mozilla-central/rev/df026d7e0c4a
http://hg.mozilla.org/mozilla-central/rev/74c7d8570af1

Comment 10

[[e-mail]]

For some reason this breaks my builds because LayerManagerD3D9.cpp uses do_GetService without explicitly including nsServiceManagerUtils.h (I don't know what normally includes it, might be the D2D surface perhaps.)