Closed Bug 620669 Opened 9 years ago Closed 9 years ago

d3d9 layout does not compile on mingw

Categories

(Core :: Graphics, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b9

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
There are two regressions:

- After landing 615316, ImageLayerD3D9.cpp uses __uuidof expression that is not yet supported on GCC. In this case avoiding it is trivial.

- After landing bug 594874, LayerManagerD3D9.cpp uses do_GetService, but doesn't include nsServiceManagerUtils.h. It assumes instead that it's included by headers it includes. It's more related to config than a compiler (included files depend on things like CAIRO_HAS_D2D_SURFACE in LayerManagerD3D9.cpp, CAIRO_HAS_DWRITE_FONT in gfxWindowsPlatform.h and probably a few more) and in my case it's not included. An explicit include seems right.
Attachment #499004 - Flags: review?
Attachment #499004 - Flags: review? → review+
Attachment #499004 - Flags: approval2.0?
Thanks for quick review.
Assignee: nobody → jacek
Attachment #499004 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/b0c6a324e72f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla2.0b9
You need to log in before you can comment on or make changes to this bug.