Closed
Bug 620669
Opened 14 years ago
Closed 14 years ago
d3d9 layout does not compile on mingw
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b9
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
1.28 KB,
patch
|
bas.schouten
:
review+
mossop
:
approval2.0+
|
Details | Diff | Splinter Review |
There are two regressions:
- After landing 615316, ImageLayerD3D9.cpp uses __uuidof expression that is not yet supported on GCC. In this case avoiding it is trivial.
- After landing bug 594874, LayerManagerD3D9.cpp uses do_GetService, but doesn't include nsServiceManagerUtils.h. It assumes instead that it's included by headers it includes. It's more related to config than a compiler (included files depend on things like CAIRO_HAS_D2D_SURFACE in LayerManagerD3D9.cpp, CAIRO_HAS_DWRITE_FONT in gfxWindowsPlatform.h and probably a few more) and in my case it's not included. An explicit include seems right.
Attachment #499004 -
Flags: review?
|
||
Updated•14 years ago
|
Attachment #499004 -
Flags: review? → review+
|
Assignee | |
Updated•14 years ago
|
Attachment #499004 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #499004 -
Flags: approval2.0? → approval2.0+
|
||
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla2.0b9
You need to log in
before you can comment on or make changes to this bug.
Description
•