595017 - Consider setting setActiveGroupItem earlier to alleviate race conditions with onTabSelect

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Aza Raskin [:aza]]

From tabbrowser.xml

>+  getActiveGroupName: function Tabview_getActiveGroupName(){
>+    // We get the active group this way, instead of querying
>+    // GroupItems.getActiveGroupItem() because the tabSelect event
>+    // will not have happened by the time the browser tries to
>+    // update the title.
>+    var activeTab = window.gBrowser.selectedTab;
>+    if( activeTab.tabItem && activeTab.tabItem.parent ){
>+      var groupName = activeTab.tabItem.parent.getTitle();
>+      if( groupName )
>+        return groupName;
>+    }
>+    return null;
>+  },  

Consider setting setActiveGroupItem earlier so that we can use getActiveGroupItem here instead?

Comment 1

[Aza Raskin [:aza]]

This is related to bug https://bugzilla.mozilla.org/show_bug.cgi?id=587099

Comment 2

[Justin Dolske [:Dolske]]

Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.