595188 - [SeaMonkey 2.1, mochitest-browser-chrome] TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_bug594509.js | about:rights content loaded

Status: VERIFIED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Bruno 'Aqualon' Escherl]

Attachment: log of testrun

This failure is quite strange. The test runs fine alone, but fails if I run all tests from toolkit/content/tests/browser/

The strang thing is, I first get this output:

TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_bug594509.js | about:rights loaded
Document about:rights loaded successfully
TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_bug594509.js | about:rights content loaded
TEST-INFO | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_bug594509.js | Test took 0.351s to complete

After that comes the next test:

TEST-START | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_save_resend_postdata.js

And directly after that I get the test failure:

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_bug594509.js | about:rights content loaded
JavaScript error: , line 0: uncaught exception: 2147942487

I've attached the whole testrun log, if I've overlooked something.

Comment 1

[Serge Gautherie (:sgautherie)]

This is a new test, added by bug 594509:
http://hg.mozilla.org/mozilla-central/rev/c966fbc9ffd4

Just guessing, but it looks like maybe gBrowser.removeTab(tab); is not processed before the next test starts, and that executeSoon(finish); might help !?

Comment 2

[Justin Wood (:Callek)]

(In reply to comment #1)
> This is a new test, added by bug 594509:
> http://hg.mozilla.org/mozilla-central/rev/c966fbc9ffd4
> 
> Just guessing, but ...

Good guess but wrong.

The problem is that this test RUNS and PASSES just fine...

TEST-START | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_bug594509.js
TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_bug594509.js | about:rights loaded
TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_bug594509.js | about:rights content loaded
TEST-INFO | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_bug594509.js | Test took 0.351s to complete

THEN

TEST-PASS | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_bug594509.js | about:rights loaded
TEST-START | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_save_resend_postdata.js
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/content/tests/browser/browser_bug594509.js | about:rights content loaded

The reason is that the 594509 test does not _unregister_ its load listener.

CC-ing author, the person who pushed and reviewer of this.

Comment 3

[Justin Wood (:Callek)]

Attachment: Fix it

This properly removes the event listener. I'm still unsure on why this doesn't fail on Firefox.

Comment 4

[Justin Wood (:Callek)]

Attachment: better fix. [Checked in: Comment 8]

better fix

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> Good guess but wrong.
> The problem is that this test RUNS and PASSES just fine...
> The reason is that the 594509 test does not _unregister_ its load listener.

Yes, that is exactly what I meant:
I just assumed actually removing the tab does/would remove its listener too.
But maybe was I wrong at that?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #5)
> I just assumed actually removing the tab does/would remove its listener too.
> But maybe was I wrong at that?

No, that's right. But SeaMonkey's removeTab apparently triggers a synchronous about:blank load...

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> But SeaMonkey's removeTab apparently triggers a synchronous
> about:blank load...

(Ah, I had forgotten about that ;->)

Comment 8

[Ian Neal]

Comment on attachment 474319 [details] [diff] [review]
better fix. [Checked in: Comment 8]

http://hg.mozilla.org/mozilla-central/rev/734eb9e00120

Comment 9

[Serge Gautherie (:sgautherie)]

V.Fixed, per
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284815013.1284818289.1169.gz
OS X 10.5 comm-central-trunk debug test mochitest-other on 2010/09/18 06:03:33