browser_394759.js seems to hit network with dns failures

RESOLVED FIXED in Firefox 6

Status

()

--
trivial
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: zpao, Assigned: Ehsan)

Tracking

Trunk
Firefox 7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox6 fixed)

Details

Attachments

(1 attachment)

At least when running the test locally. It doesn't cause failures, but we shouldn't do it.

It's because we try to go to windowN.example.com. Simon actually brought this up in review, and I said meh because it didn't actually matter.

But now it's annoying to see comcast's dns error page in tests, so I want to fix it.
(Assignee)

Comment 1

8 years ago
I bet this is actually the cause of bug 570192.  It might make the test time out because of DNS query timeout for example (in which case the load event won't fire, I think).  The fix is really simple, and I think it's worth taking.
Assignee: nobody → ehsan
Blocks: 570192
(Assignee)

Comment 2

8 years ago
Created attachment 541106 [details] [diff] [review]
Patch (v1)
Attachment #541106 - Flags: review?(paul)
Comment on attachment 541106 [details] [diff] [review]
Patch (v1)

Review of attachment 541106 [details] [diff] [review]:
-----------------------------------------------------------------

I've been meaning to go back through and find bugs like this. Thanks for just doing it.
Attachment #541106 - Flags: review?(paul) → review+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/b060d115f501
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7

Comment 5

8 years ago
(In reply to comment #0)
comcast++ (!)
Comment on attachment 541106 [details] [diff] [review]
Patch (v1)

Requesting mozilla-approval-aurora.  This is a one-line patch to prevent a test from requesting a remote page over the internet.  The test became permaorange starting yesterday because of some infrastructure change or external change, and is still permaorange on Aurora.  So far releng has not been able to figure out what might have changed to trigger the failures.  This patch has landed on mozilla-central so the test is no longer failing there.

Landing this test-only change on Aurora now will allow us to have green tests for Firefox 6 as it goes through Aurora, Beta, and Release.
Attachment #541106 - Flags: approval-mozilla-aurora?
Comment on attachment 541106 [details] [diff] [review]
Patch (v1)

a=drivers for this test-only change.

Updated

8 years ago
Attachment #541106 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Hello.

Is there a way in which this issue can be verified? Some simple STR or a test case?
You need to log in before you can comment on or make changes to this bug.