[tracking bug] stop loading external URLs in test suites

RESOLVED FIXED

Status

Testing
General
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: bhearsum, Assigned: ted)

Tracking

({meta})

Trunk
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(8 attachments)

(Reporter)

Description

7 years ago
This bug is a meta bug to track fixing all tests which load external URLs.
Depends on: 605884
(Reporter)

Updated

7 years ago
Depends on: 627011
Depends on: 627292
(Assignee)

Comment 1

7 years ago
Created attachment 506990 [details]
mochitest-browser-chrome wireshark packet capture log

I ran mochitest-browser-chrome with Wireshark running, and here's the packet capture log. I tried to exclude my local network traffic, but a bunch of it slipped in anyway. Sorry about that.
Depends on: 628866
Depends on: 628867
Depends on: 628873
(Reporter)

Comment 2

7 years ago
(In reply to comment #1)
> Created attachment 506990 [details]
> mochitest-browser-chrome wireshark packet capture log
> 
> I ran mochitest-browser-chrome with Wireshark running, and here's the packet
> capture log. I tried to exclude my local network traffic, but a bunch of it
> slipped in anyway. Sorry about that.

Thanks!
(Assignee)

Comment 3

7 years ago
Created attachment 507085 [details]
mochitest-chrome wireshark packet capture log

mochitest-chrome is not terribly interesting, it's got the stock live bookmarks stuff, but nothing else AFAICT.

There's an interesting request at the beginning that I didn't notice in the browser-chrome log, although I assume it's there as well. Apparently we GET http://www.mozilla.org/ looking for a microsummary or something? It looks like:

GET / HTTP/1.1
Host: www.mozilla.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110105 Firefox/4.0b9pre
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip, deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 115
Connection: keep-alive
X-Moz: microsummary
(Assignee)

Comment 4

7 years ago
Created attachment 507087 [details]
mochitest-1/5 wireshark packet capture log

Here's mochitest-1/5. There are a couple of interesting things in this log, I'll file some bugs. Conveniently, we get Referer headers when normal Mochitests do HTTP requests. :)
(Assignee)

Updated

7 years ago
Depends on: 628966
(Assignee)

Updated

7 years ago
Depends on: 628970
(Assignee)

Comment 5

7 years ago
Created attachment 507092 [details]
mochitest-2/5 wireshark packet capture log

Here's mochitest-2/5, which only seems to have one misbehaving test.
(Assignee)

Updated

7 years ago
Depends on: 628974
(Assignee)

Comment 6

7 years ago
Created attachment 507096 [details]
mochitest-3/5 wireshark packet capture log

mochitest-3/5 also has only one misbehaving test.
(Assignee)

Updated

7 years ago
Depends on: 628980
(Assignee)

Comment 7

7 years ago
Created attachment 507105 [details]
mochitest-4/5 wireshark packet capture log

mochitest-4/5 appears to have no offenders. Hooray!
(Assignee)

Comment 8

7 years ago
Created attachment 507106 [details]
mochitest-5/5 wireshark packet capture log

mochitest-5/5 has just one naughty test.
(Assignee)

Updated

7 years ago
Depends on: 628984
(Assignee)

Comment 9

7 years ago
Created attachment 507128 [details]
xpcshell wireshark packet capture log

reftest and crashtest were totally clean runs. Hooray! xpcshell seems to hit https://www.google.com/, but for the life of me I cannot find where that's happening.
(Assignee)

Comment 10

7 years ago
jstestbrowser and mochitest-a11y were also clean runs. I think I'm done here.
(In reply to comment #3)
> There's an interesting request at the beginning that I didn't notice in the
> browser-chrome log, although I assume it's there as well. Apparently we GET
> http://www.mozilla.org/ looking for a microsummary or something? It looks like:
> 
> GET / HTTP/1.1
> Host: www.mozilla.org
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110105
> Firefox/4.0b9pre
> Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
> Accept-Language: en-us,en;q=0.5
> Accept-Encoding: gzip, deflate
> Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
> Keep-Alive: 115
> Connection: keep-alive
> X-Moz: microsummary
I looked last night and couldn't actually find the test for this.  Starting to think maybe it's something in the browser code?
(Assignee)

Comment 12

7 years ago
Yeah, I have no idea how the microsummary code works. Presumably it's getting run on some of the default bookmarks?
(In reply to comment #12)
> Yeah, I have no idea how the microsummary code works. Presumably it's getting
> run on some of the default bookmarks?
Oh!  That's possible :/
(Reporter)

Updated

7 years ago
Blocks: 617414
Depends on: 629851
Depends on: 509966
Keywords: meta
Version: unspecified → Trunk
No longer depends on: 627011
Depends on: 633846
No longer depends on: 627292
No longer depends on: 605884
So will the test prefs change from a .PAC file to routing everything through the JS proxy server, allowing it to log bogus requests?
(Assignee)

Comment 15

7 years ago
I don't know of any plans to do that at this time, but that sounds like it would be a useful path to take. See also bug 616182, which requests that we return a fixed IP for all DNS lookups controlled via a pref.
(Assignee)

Comment 16

6 years ago
There doesn't seem to be anything left to do here. We can reopen this if something is broken in the meantime.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Depends on: 657190
(Reporter)

Updated

6 years ago
Depends on: 663211
(Reporter)

Updated

6 years ago
Depends on: 663372
(Reporter)

Comment 17

6 years ago
Re-opening because there's a couple new dependent bugs.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 18

6 years ago
Fixed again. :)
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Assignee: nobody → ted.mielczarek
Depends on: 731332
Depends on: 595292
Depends on: 691005
You need to log in before you can comment on or make changes to this bug.