626999 - [tracking bug] stop loading external URLs in test suites

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[[e-mail] (:bhearsum)]

This bug is a meta bug to track fixing all tests which load external URLs.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: mochitest-browser-chrome wireshark packet capture log

I ran mochitest-browser-chrome with Wireshark running, and here's the packet capture log. I tried to exclude my local network traffic, but a bunch of it slipped in anyway. Sorry about that.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to comment #1)
> Created attachment 506990 [details]
> mochitest-browser-chrome wireshark packet capture log
> 
> I ran mochitest-browser-chrome with Wireshark running, and here's the packet
> capture log. I tried to exclude my local network traffic, but a bunch of it
> slipped in anyway. Sorry about that.

Thanks!

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: mochitest-chrome wireshark packet capture log

mochitest-chrome is not terribly interesting, it's got the stock live bookmarks stuff, but nothing else AFAICT.

There's an interesting request at the beginning that I didn't notice in the browser-chrome log, although I assume it's there as well. Apparently we GET http://www.mozilla.org/ looking for a microsummary or something? It looks like:

GET / HTTP/1.1
Host: www.mozilla.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110105 Firefox/4.0b9pre
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip, deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 115
Connection: keep-alive
X-Moz: microsummary

Comment 4

[(not currently active) Ted Mielczarek]

Attachment: mochitest-1/5 wireshark packet capture log

Here's mochitest-1/5. There are a couple of interesting things in this log, I'll file some bugs. Conveniently, we get Referer headers when normal Mochitests do HTTP requests. :)

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: mochitest-2/5 wireshark packet capture log

Here's mochitest-2/5, which only seems to have one misbehaving test.

Comment 6

[(not currently active) Ted Mielczarek]

Attachment: mochitest-3/5 wireshark packet capture log

mochitest-3/5 also has only one misbehaving test.

Comment 7

[(not currently active) Ted Mielczarek]

Attachment: mochitest-4/5 wireshark packet capture log

mochitest-4/5 appears to have no offenders. Hooray!

Comment 8

[(not currently active) Ted Mielczarek]

Attachment: mochitest-5/5 wireshark packet capture log

mochitest-5/5 has just one naughty test.

Comment 9

[(not currently active) Ted Mielczarek]

Attachment: xpcshell wireshark packet capture log

reftest and crashtest were totally clean runs. Hooray! xpcshell seems to hit https://www.google.com/, but for the life of me I cannot find where that's happening.

Comment 10

[(not currently active) Ted Mielczarek]

jstestbrowser and mochitest-a11y were also clean runs. I think I'm done here.

Comment 11

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> There's an interesting request at the beginning that I didn't notice in the
> browser-chrome log, although I assume it's there as well. Apparently we GET
> http://www.mozilla.org/ looking for a microsummary or something? It looks like:
> 
> GET / HTTP/1.1
> Host: www.mozilla.org
> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110105
> Firefox/4.0b9pre
> Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
> Accept-Language: en-us,en;q=0.5
> Accept-Encoding: gzip, deflate
> Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
> Keep-Alive: 115
> Connection: keep-alive
> X-Moz: microsummary
I looked last night and couldn't actually find the test for this.  Starting to think maybe it's something in the browser code?

Comment 12

[(not currently active) Ted Mielczarek]

Yeah, I have no idea how the microsummary code works. Presumably it's getting run on some of the default bookmarks?

Comment 13

[Shawn Wilsher :sdwilsh]

(In reply to comment #12)
> Yeah, I have no idea how the microsummary code works. Presumably it's getting
> run on some of the default bookmarks?
Oh!  That's possible :/

Comment 14

[[e-mail]]

So will the test prefs change from a .PAC file to routing everything through the JS proxy server, allowing it to log bogus requests?

Comment 15

[(not currently active) Ted Mielczarek]

I don't know of any plans to do that at this time, but that sounds like it would be a useful path to take. See also bug 616182, which requests that we return a fixed IP for all DNS lookups controlled via a pref.

Comment 16

[(not currently active) Ted Mielczarek]

There doesn't seem to be anything left to do here. We can reopen this if something is broken in the meantime.

Comment 17

[[e-mail] (:bhearsum)]

Re-opening because there's a couple new dependent bugs.

Comment 18

[(not currently active) Ted Mielczarek]

Fixed again. :)