595487 - Change "Update Add-ons Now" to "Check For Add-on Updates"

Status: VERIFIED DUPLICATE of bug 590756

(Toolkit :: Add-ons Manager, defect)

Description

[imradyurrad]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b6pre) Gecko/20100910 Firefox/4.0b6pre
Build Identifier: 

"Update Add-ons Now" is presuming there are available updates to add-ons.
That's not what you're doing when clicking on it. You're checking to see if there are updates available. Update Add-ons Now should only be visible when it's already been determined that updates for installed add-ons are available. 

Another thing, when FF is checking for addons, it says "Updating addons". This is false, it's merely checking for updates. 

Reproducible: Always

Comment 1

[Dave Garrett]

+"Add-on"; needs to keep the word to not imply checking for app updates.

Comment 2

[imradyurrad]

(In reply to comment #1)
> +"Add-on"; needs to keep the word to not imply checking for app updates.

I thought so too but that's a given. It's common sense that if you're in the AOM, you're updating the add-ons, not Firefox.

Comment 3

[Dave Garrett]

This is a bug to suggest changing words to prevent confusion, under the assumption that "common sense" is inadequate to know that the current string is for just checking. Thus, if we're going to be explicit we should be fully explicit. Don't assume the user knows what any of this is.

There's a further issue here, though I am then expanding the scope of this bug a little bit: When you're in the extensions pane is it only updating extensions? When in the theme pane is it only updating themes? It should really say what it's actually checking for, because I've never been to clear on this one myself. So instead it should be: "Check For Extension Updates" & etc. OR "Check For All Add-on Updates" if they're all checked at once.

Comment 4

[imradyurrad]

(In reply to comment #3)

Doesn't the term "add-ons" encompass both extensions AND themes? 
And clicking on "Update Add-ons" checks for both, am I incorrect?

Comment 5

[Dave Garrett]

(In reply to comment #4)
> Doesn't the term "add-ons" encompass both extensions AND themes? 

Yes. (and plugins, and language packs, and dictionaries, and search providers, and lightweight themes, and lightweight extensions...)

> And clicking on "Update Add-ons" checks for both, am I incorrect?

I don't know, and if I'm not sure then the average user certainly isn't going to know either, which is why I think clarification of some kind is needed.

Comment 6

[Dave Garrett]

In the old Extension Manager I'm pretty sure each button only worked on each pane, and I ~think~ that's what it's doing now, at least maybe for plugins it's checking separately. I don't know. Again, this should be unambiguous; your initial point of filing this bug is quite valid, I'm just saying it covers more.