595509 - default search no longer working in location bar

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Regressed somewhere between Sept 10 and Sept 11 nightlies:

Steps to reproduce:
1. Type "sad face" in the location bar
2. Hit enter

Expected: http://www.google.ca/search?q=sad+face&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:en-US:unofficial&client=firefox-a

Actual: JS alert "The URL is not valid and cannot be loaded."

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Adding Gavin, as he touched this last, but not sure what could have happened in the past few days to make this go away.

(Also adding Jono, in case this was one of the prefs that Test Pilot might have overwritten)

Comment 2

[juan becerra [:juanb]]

Happens on XP and Mac as well.

Comment 3

[Alice0775 White]

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cca361001fda&tochange=2a216165e361
Bug 589613 - [SeaMonkey 2.1, mochitest-browser-chrome] browser_Services.js | Services.search exists

Comment 4

[Justin Wood (:Callek)]

Attachment: Fix [Empty diff]

Sorry...

I will be unable to land this until monday or tuesday night, so feel free to push on my behalf. And if this needs a test, Tuesday night is earliest.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: test

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I fixed this by backing out 589613.

https://hg.mozilla.org/mozilla-central/rev/84baf90b040c

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: test

I made sure that this doesn't actually depend on the network (works even if the page fails to load).

Comment 8

[Ian Neal]

Attachment: Test that does not crash / timeout when it fails v0.1

Not sure if this is the best way of resolving the issue of when the Alert is triggered, but I did notice that if the Alert is left open then the test eventually generates a mini-dump.

Comment 9

[Ian Neal]

Attachment: Test that does not crash / timeout when it fails v0.1 (once refreshed)

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 474406 [details] [diff] [review]
Test that does not crash / timeout when it fails v0.1 (once refreshed)

This needs to unregisterNotification in the success case, otherwise it will likely interfere with other tests.

Comment 11

[Ian Neal]

Attachment: Test that does not crash / timeout when it fails with observer unregister patch v0.2 [Checked in: Comment 12]

Changes since v0.1:
* Unregister observer in success case;
* Use "this" instead of "listener" in ProgressListener removal.

Comment 12

[Ian Neal]

Comment on attachment 474441 [details] [diff] [review]
Test that does not crash / timeout when it fails with observer unregister patch v0.2 [Checked in: Comment 12]

http://hg.mozilla.org/mozilla-central/rev/28ff9550b120