595555 - JSOPTION_ANONFUNFIX should be set in js shell

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brendan Eich [:brendan]]

This option makes eval("function(){}") an error, per ECMA-262. The eval is just for example, another example would be (in HTML):

<script>function(){};</script>

An anonymous function expression as the whole expression in an expression statement was allowed in the ancient days, in particular for the eval use-case, and people came to count on it. Other browsers even cloned this extension.

We dropped support by enabling JSOPTION_ANONFUNFIX with bug 377433.

Setting this in the shell will require testsuite and fuzzer adjustments.

/be

Comment 1

[Brendan Eich [:brendan]]

Not taking assignment but I'll help if someone cc'ed can -- anyone?

/be

Comment 2

[Jesse Ruderman]

jsfunfuzz currently calls 'options("anonfunfix");' whenever it detects that it's in a Spidermonkey shell.  Depending on the fix here, this might need to be changed.

Comment 3

[Brendan Eich [:brendan]]

Attachment: fix (mostly trace-tests)

Need someone with fresh eyes to plug-n-chug per the ASI rules.

/be

Comment 4

[Chris Leary [:cdleary] (not checking bugmail)]

Comment on attachment 481231 [details] [diff] [review]
fix (mostly trace-tests)

Looks like the only interesting one is that last PIC test. (Which has \r\n line endings, blech!)

-s = [function() function() function() function() function() function() {}]
-[function() function() function() function() {}]
-function() { [function() function() {}] }
-function() {}
+s = [function() function() function() function() function() function() {}];
+[function() function() function() function() {}];
+(function() { [function() function() {}] });
+(function() {});

That one is actually different by ASI rules, since the second brackety deal will index into the first in the original, producing s as a result. ASI would occur before the third and fourth lines in the original.

Comment 5

[Brendan Eich [:brendan]]

http://hg.mozilla.org/tracemonkey/rev/d5eb3c44d131

/be

Comment 6

[Brendan Eich [:brendan]]

http://hg.mozilla.org/mozilla-central/rev/d5eb3c44d131

/be