595708 - "nsDocument.cpp(4377) : error C2248: 'nsAString_internal::nsAString_internal' : cannot access protected member declared in class 'nsAString_internal'"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Serge Gautherie (:sgautherie)]

(I hadn't tried to build locally for a long time...)

{
.../nsDocument.cpp(4377) : error C2248: 'nsAString_internal::nsAString_internal' : cannot access protected member declared in class 'nsAString_internal'
        ...\dist\include\nsTSubstring.h(612) : see declaration of 'nsAString_internal::nsAString_internal'
        ...\dist\include\nsTSubstring.h(86) : see declaration of 'nsAString_internal'

.../nsDocument.cpp(5816) : warning C4018: '<' : signed/unsigned mismatch
}

http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsDocument.cpp
4377   rv = CreateElem(needsLowercase ? lcTagName : aTagName, nsnull,
4378                   IsHTML() ? kNameSpaceID_XHTML : GetDefaultNamespaceID(),
4379                   PR_TRUE, aReturn);

Latest blame is to bug 566466...

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I wonder which compiler gives you that error.
And what/where the error actually is.

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)

{
Platform SDK directory: [...]\Microsoft Platform SDK for Windows Server 2003 R2
Platform SDK version: 5
Setting environment for using Microsoft Visual Studio 2005 x86 tools.

  --with-windows-version=502
  --disable-ctypes
  --disable-ipc
  --disable-webm
  --enable-application=browser
}

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)

The error is triggered by |needsLowercase ? lcTagName : aTagName|.

If I use lcTagName or aTagName only then it compiles.
If I use |needsLowercase ? (const nsAString&) lcTagName : aTagName| then it compiles too...

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Serge, could you post a patch? And use C++ casting if possible.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Add a |static_cast<const nsAString&>|, 1 s/PRInt32/PRUint32/ [Checked in: Comment 7]

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 474670 [details] [diff] [review]
(Av1) Add a |static_cast<const nsAString&>|, 1 s/PRInt32/PRUint32/
[Checked in: Comment 7]

"approval2.0=?":
Fix a compile error and a warning: no risk.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 474670 [details] [diff] [review]
(Av1) Add a |static_cast<const nsAString&>|, 1 s/PRInt32/PRUint32/
[Checked in: Comment 7]

http://hg.mozilla.org/mozilla-central/rev/5e71c3a0b5c1