Require SP1 of VC8 EE to build (successfully)

RESOLVED FIXED in mozilla2.0b9

Status

()

Core
Build Config
--
major
RESOLVED FIXED
7 years ago
3 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

(Blocks: 1 bug)

Trunk
mozilla2.0b9
x86
Windows 2000
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(status1.9.2 wontfix, status1.9.1 wontfix)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
I used to build with bare Visual C++ 8 Express Edition (= without Service Pack 1).

"Recently", it couldn't build trunk anymore: bug 595708, which I "fixed".
Then, it broke with bug 595756 and later with bug 605569, which I failed to work around.

Today, I eventually applied SP1 and succeeded to build an Opt Firefox :-)

Then I suggest to add a configure check to require SP1 (or newer) to build trunk.

What do you think?

***

https://developer.mozilla.org/En/Windows_Build_Prerequisites
NB: SP1 is already required to build jemalloc and installed on tinderboxes.

Ftr, VC 8 EE which 'cl' outputs:
*noSP: Version 14.00.50727.42
*SP1 : Version 14.00.50727.762
Fine with me as long as you produce a reasonable error message.
(Assignee)

Comment 2

7 years ago
Created attachment 489552 [details] [diff] [review]
(Av1-MC) Obsolete VC7.1 and VC8 without its SP1
[Checked in: Comment 4]

After that one is checked in, I'll update other configure.in files and the wiki page.
Assignee: nobody → sgautherie.bz
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #489552 - Flags: review?(ted.mielczarek)
Attachment #489552 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

7 years ago
Comment on attachment 489552 [details] [diff] [review]
(Av1-MC) Obsolete VC7.1 and VC8 without its SP1
[Checked in: Comment 4]

"approval2.0=?":
Update m-c configure.in to error out on too old/broken MSVC compilers. No risk.
Attachment #489552 - Flags: approval2.0?
Attachment #489552 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 4

7 years ago
Comment on attachment 489552 [details] [diff] [review]
(Av1-MC) Obsolete VC7.1 and VC8 without its SP1
[Checked in: Comment 4]

http://hg.mozilla.org/mozilla-central/rev/3492dbd5ff50
Attachment #489552 - Attachment description: (Av1-MC) Obsolete VC7.1 and VC8 without its SP1. → (Av1-MC) Obsolete VC7.1 and VC8 without its SP1 [Checked in: Comment 4]
(Assignee)

Comment 5

7 years ago
Created attachment 493205 [details] [diff] [review]
(Bv1-JS) Obsolete VC7.1 and VC8 without its SP1
[Checked in: Comment 9]

Same as patch Av1-MC, but with js file context.
Attachment #493205 - Flags: review?(ted.mielczarek)
Attachment #493205 - Flags: approval2.0?
(Assignee)

Comment 6

7 years ago
Created attachment 493210 [details] [diff] [review]
(Cv1-CC) Obsolete VC7.1 and VC8 without its SP1
[Checked in: Comment 8]

Same as patch Av1-MC, but with c-c file context.
Attachment #493210 - Flags: review?(bugspam.Callek)
(Assignee)

Updated

7 years ago
Blocks: 614769
(Assignee)

Comment 7

7 years ago
(In reply to comment #0)
> https://developer.mozilla.org/En/Windows_Build_Prerequisites

Update done:

1) branch/compiler table.

I added "4 VC8 SP1 (service pack 1) is now required."

2) "Building Gecko 1.9.0 or later" block

I replaced
"Projects that are built on Gecko 1.9.0 (such as Firefox 3.0) require that you use Visual C++ 7.1 (Visual Studio 2003), Visual C++ 8 (Visual Studio 2005) or Visual C++ 9 (Visual Studio 2008)."
with
"See table above for which Visual C++ versions can be used to compile the version of the Mozilla codebase you are interested in."

Updated

7 years ago
Attachment #493210 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 8

7 years ago
Comment on attachment 493210 [details] [diff] [review]
(Cv1-CC) Obsolete VC7.1 and VC8 without its SP1
[Checked in: Comment 8]

http://hg.mozilla.org/comm-central/rev/ec333bbd25ae
Attachment #493210 - Attachment description: (Cv1-CC) Obsolete VC7.1 and VC8 without its SP1 → (Cv1-CC) Obsolete VC7.1 and VC8 without its SP1 [Checked in: Comment 8]
Attachment #493205 - Flags: review?(ted.mielczarek) → review+
Attachment #493205 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 9

7 years ago
Comment on attachment 493205 [details] [diff] [review]
(Bv1-JS) Obsolete VC7.1 and VC8 without its SP1
[Checked in: Comment 9]

http://hg.mozilla.org/mozilla-central/rev/59606b331b0e
Attachment #493205 - Attachment description: (Bv1-JS) Obsolete VC7.1 and VC8 without its SP1 → (Bv1-JS) Obsolete VC7.1 and VC8 without its SP1 [Checked in: Comment 9]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
(Assignee)

Comment 10

7 years ago
Created attachment 501042 [details] [diff] [review]
(Dv1-M192) Obsolete VC7.1, Fix VC8SP1 check

Backport Av1-MC and Bv1-JS to m-1.9.2.
Attachment #501042 - Flags: review?(ted.mielczarek)
Comment on attachment 501042 [details] [diff] [review]
(Dv1-M192) Obsolete VC7.1, Fix VC8SP1 check

Not worth taking on the stable branch.
Attachment #501042 - Flags: review?(ted.mielczarek) → review-
(Assignee)

Updated

7 years ago
Blocks: 622868
(Assignee)

Updated

7 years ago
status1.9.1: --- → wontfix
status1.9.2: --- → wontfix
(Assignee)

Updated

7 years ago
Blocks: 602920
No longer blocks: 602920
(In reply to comment #11)
> (From update of attachment 501042 [details] [diff] [review])
> 
> Not worth taking on the stable branch.

Doesn't 1.9.2 compile with regular VC8 anyway? I know it mostly compiles with VC7.1 too, there are a few issues in js/src with a pending(!) patch.

Updated

7 years ago
Blocks: 626716
(Assignee)

Updated

6 years ago
Attachment #501042 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Blocks: 523268
(Assignee)

Updated

3 years ago
Blocks: 510493
You need to log in before you can comment on or make changes to this bug.