595719 - Shark nightly builds burning from "invalid conversion from 'const char*' to 'char*'" in jsprobes.h since Sept. 2 on TM, post-merge on m-c

Status: RESOLVED DUPLICATE of bug 593483

(Core :: JavaScript Engine, defect)

Description

[Phil Ringnalda (:philor)]

Something in the range http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=319b1a4e08837c9e7c2d6cabee5a6642a514decc&tochange=86d684e6ea095f60e6c2a0e1fa5fe70d30228598 broke the Shark nightly builds on tracemonkey, and then since it went unnoticed, broke them on mozilla-central after the merge.

g++-4.2 -o jsbool.o -c  -fvisibility=hidden -DOSTYPE=\"Darwin9.2.0\" -DOSARCH=Darwin -DEXPORT_JS_API -D__STDC_LIMIT_MACROS -DJS_HAS_CTYPES -DDLL_PREFIX=\"lib\" -DDLL_SUFFIX=\".dylib\" -Ictypes/libffi/include -I.  -I/builds/slave/tracemonkey-macosx-shark/build/js/src -I. -I./../../dist/include -I./../../dist/include/nsprpub  -I/builds/slave/tracemonkey-macosx-shark/build/obj-firefox/dist/include/nspr   -I/builds/slave/tracemonkey-macosx-shark/build/js/src -I/builds/slave/tracemonkey-macosx-shark/build/js/src/assembler -I/builds/slave/tracemonkey-macosx-shark/build/js/src/yarr  -fPIC  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -gdwarf-2 -isysroot /Developer/SDKs/MacOSX10.5.sdk -fno-strict-aliasing -fpascal-strings -fno-common -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -F/System/Library/PrivateFrameworks -O3 -fstrict-aliasing -fomit-frame-pointer  -F/System/Library/PrivateFrameworks -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1   -DMOZILLA_CLIENT -include ./js-confdefs.h -MD -MF .deps/jsbool.pp /builds/slave/tracemonkey-macosx-shark/build/js/src/jsbool.cpp
In file included from /builds/slave/tracemonkey-macosx-shark/build/js/src/jsobjinlines.h:50,
                 from /builds/slave/tracemonkey-macosx-shark/build/js/src/jsbool.cpp:57:
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsprobes.h: In static member function 'static void js::Probes::startExecution(JSContext*, JSScript*)':
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsprobes.h:173: error: invalid conversion from 'const char*' to 'char*'
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsprobes.h:173: error:   initializing argument 1 of 'void __dtrace_probe$javascript$execute__start$v1$63686172202a$696e74(char*, int)'
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsprobes.h: In static member function 'static void js::Probes::stopExecution(JSContext*, JSScript*)':
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsprobes.h:186: error: invalid conversion from 'const char*' to 'char*'
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsprobes.h:186: error:   initializing argument 1 of 'void __dtrace_probe$javascript$execute__done$v1$63686172202a$696e74(char*, int)'
In file included from /builds/slave/tracemonkey-macosx-shark/build/js/src/jsobjinlines.h:50,
                 from /builds/slave/tracemonkey-macosx-shark/build/js/src/jsatom.cpp:65:
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsprobes.h: In static member function 'static void js::Probes::startExecution(JSContext*, JSScript*)':
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsprobes.h:173: error: invalid conversion from 'const char*' to 'char*'
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsprobes.h:173: error:   initializing argument 1 of 'void __dtrace_probe$javascript$execute__start$v1$63686172202a$696e74(char*, int)'
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsprobes.h: In static member function 'static void js::Probes::stopExecution(JSContext*, JSScript*)':
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsprobes.h:186: error: invalid conversion from 'const char*' to 'char*'
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsprobes.h:186: error:   initializing argument 1 of 'void __dtrace_probe$javascript$execute__done$v1$63686172202a$696e74(char*, int)'
make[4]: *** [jsbool.o] Error 1

Comment 1

[Phil Ringnalda (:philor)]

Had I gotten far enough to see that it was actually --enable-dtrace rather than --enable-shark that was broken, I might have realized it was already filed and I'd already seen the bug, without quite realizing that it meant a permared build on mozilla-central once we merged.