Closed
Bug 595759
Opened 14 years ago
Closed 14 years ago
Port |Bug 569268 - Package correct Visual C++ CRT DLLs based on compiler version (fixes MSVCR100.dll error message on startup)| to SeaMonkey
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b3
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
Attachments
(1 file)
2.62 KB,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284332817.1284339902.4598.gz&fulltext=1 WINNT 5.2 comm-central-trunk leak test build on 2010/09/12 16:06:57 { Warning: package error or possible missing or unnecessary file: bin/Microsoft.VC80.CRT.manifest (package-manifest, 41). Warning: package error or possible missing or unnecessary file: bin/msvcm80.dll (package-manifest, 42). Warning: package error or possible missing or unnecessary file: bin/msvcp80.dll (package-manifest, 43). Warning: package error or possible missing or unnecessary file: bin/msvcr80.dll (package-manifest, 44). -bin/Microsoft.VC80.CRT.manifest -bin/msvcm80.dll -bin/msvcp80.dll -bin/msvcr80.dll } This could probably be a bug 565774 duplicate, but I prefer to fill it separately, just in case.
Flags: in-testsuite-
Assignee | ||
Comment 1•14 years ago
|
||
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #474617 -
Flags: review?(bugspam.Callek)
Comment 2•14 years ago
|
||
Comment on attachment 474617 [details] [diff] [review] (Av1) Just copy it, Add removed-files.in part [Checked in: Comment 5] I feel safer deferring to KaiRo on this one, as I'm not sure on the "we should package x" for MSVC* stuff.
Attachment #474617 -
Flags: review?(bugspam.Callek) → review?(kairo)
Assignee | ||
Comment 3•14 years ago
|
||
KaiRo, ping for review. Fwiw, TB has now ported bug 569268 in bug 630857.
Comment 4•14 years ago
|
||
Comment on attachment 474617 [details] [diff] [review] (Av1) Just copy it, Add removed-files.in part [Checked in: Comment 5] actually stealing the review back; I have spent some time looking into related stuff recently. I'm not exactly LIKING the removed-files code here, but I agree it is "correct" (we could suffice with strictly what we ship, but no big deal).
Attachment #474617 -
Flags: review?(kairo) → review+
Assignee | ||
Comment 5•14 years ago
|
||
Comment on attachment 474617 [details] [diff] [review] (Av1) Just copy it, Add removed-files.in part [Checked in: Comment 5] http://hg.mozilla.org/comm-central/rev/489165ce4714
Attachment #474617 -
Attachment description: (Av1) Just copy it, Add removed-files.in part → (Av1) Just copy it, Add removed-files.in part
[Checked in: Comment 5]
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
Assignee | ||
Comment 7•14 years ago
|
||
(In reply to comment #6) > Is this an issue with b2, i.e. something for Known Issues? It shouldn't be: our win32 release build uses jemalloc (mozcXX19.dll).
Assignee | ||
Comment 8•14 years ago
|
||
(In reply to comment #0) > This could probably be a bug 565774 duplicate Actually, this bug should not help bug 565774 ... and it didn't.
No longer blocks: 565774
Assignee | ||
Updated•13 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•