Last Comment Bug 595759 - Port |Bug 569268 - Package correct Visual C++ CRT DLLs based on compiler version (fixes MSVCR100.dll error message on startup)| to SeaMonkey
: Port |Bug 569268 - Package correct Visual C++ CRT DLLs based on compiler vers...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: x86 Windows 2000
: -- major (vote)
: seamonkey2.1b3
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
Depends on: 569268
Blocks: 713134
  Show dependency treegraph
 
Reported: 2010-09-12 21:45 PDT by Serge Gautherie (:sgautherie)
Modified: 2011-12-30 04:49 PST (History)
4 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Just copy it, Add removed-files.in part [Checked in: Comment 5] (2.62 KB, patch)
2010-09-12 22:20 PDT, Serge Gautherie (:sgautherie)
bugspam.Callek: review+
Details | Diff | Review

Description Serge Gautherie (:sgautherie) 2010-09-12 21:45:05 PDT
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284332817.1284339902.4598.gz&fulltext=1
WINNT 5.2 comm-central-trunk leak test build on 2010/09/12 16:06:57
{
Warning: package error or possible missing or unnecessary file: bin/Microsoft.VC80.CRT.manifest (package-manifest, 41).
Warning: package error or possible missing or unnecessary file: bin/msvcm80.dll (package-manifest, 42).
Warning: package error or possible missing or unnecessary file: bin/msvcp80.dll (package-manifest, 43).
Warning: package error or possible missing or unnecessary file: bin/msvcr80.dll (package-manifest, 44).

-bin/Microsoft.VC80.CRT.manifest
-bin/msvcm80.dll
-bin/msvcp80.dll
-bin/msvcr80.dll
}

This could probably be a bug 565774 duplicate, but I prefer to fill it separately, just in case.
Comment 1 Serge Gautherie (:sgautherie) 2010-09-12 22:20:15 PDT
Created attachment 474617 [details] [diff] [review]
(Av1) Just copy it, Add removed-files.in part
[Checked in: Comment 5]
Comment 2 Justin Wood (:Callek) 2010-09-16 21:11:43 PDT
Comment on attachment 474617 [details] [diff] [review]
(Av1) Just copy it, Add removed-files.in part
[Checked in: Comment 5]

I feel safer deferring to KaiRo on this one, as I'm not sure on the "we should package x" for MSVC* stuff.
Comment 3 Serge Gautherie (:sgautherie) 2011-02-15 04:30:48 PST
KaiRo, ping for review.

Fwiw, TB has now ported bug 569268 in bug 630857.
Comment 4 Justin Wood (:Callek) 2011-02-15 13:43:54 PST
Comment on attachment 474617 [details] [diff] [review]
(Av1) Just copy it, Add removed-files.in part
[Checked in: Comment 5]

actually stealing the review back; I have spent some time looking into related stuff recently. I'm not exactly LIKING the removed-files code here, but I agree it is "correct" (we could suffice with strictly what we ship, but no big deal).
Comment 5 Serge Gautherie (:sgautherie) 2011-02-15 14:47:50 PST
Comment on attachment 474617 [details] [diff] [review]
(Av1) Just copy it, Add removed-files.in part
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/489165ce4714
Comment 6 Jens Hatlak (:InvisibleSmiley) 2011-02-16 00:10:12 PST
Is this an issue with b2, i.e. something for Known Issues?
Comment 7 Serge Gautherie (:sgautherie) 2011-02-16 04:09:05 PST
(In reply to comment #6)
> Is this an issue with b2, i.e. something for Known Issues?

It shouldn't be: our win32 release build uses jemalloc (mozcXX19.dll).
Comment 8 Serge Gautherie (:sgautherie) 2011-02-16 05:08:46 PST
(In reply to comment #0)
> This could probably be a bug 565774 duplicate

Actually, this bug should not help bug 565774 ... and it didn't.

Note You need to log in before you can comment on or make changes to this bug.