Port |Bug 569268 - Package correct Visual C++ CRT DLLs based on compiler version (fixes MSVCR100.dll error message on startup)| to SeaMonkey

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Build Config
--
major
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
seamonkey2.1b3
x86
Windows 2000
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284332817.1284339902.4598.gz&fulltext=1
WINNT 5.2 comm-central-trunk leak test build on 2010/09/12 16:06:57
{
Warning: package error or possible missing or unnecessary file: bin/Microsoft.VC80.CRT.manifest (package-manifest, 41).
Warning: package error or possible missing or unnecessary file: bin/msvcm80.dll (package-manifest, 42).
Warning: package error or possible missing or unnecessary file: bin/msvcp80.dll (package-manifest, 43).
Warning: package error or possible missing or unnecessary file: bin/msvcr80.dll (package-manifest, 44).

-bin/Microsoft.VC80.CRT.manifest
-bin/msvcm80.dll
-bin/msvcp80.dll
-bin/msvcr80.dll
}

This could probably be a bug 565774 duplicate, but I prefer to fill it separately, just in case.
Flags: in-testsuite-
(Assignee)

Updated

7 years ago
Depends on: 515374
(Assignee)

Comment 1

7 years ago
Created attachment 474617 [details] [diff] [review]
(Av1) Just copy it, Add removed-files.in part
[Checked in: Comment 5]
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #474617 - Flags: review?(bugspam.Callek)
Comment on attachment 474617 [details] [diff] [review]
(Av1) Just copy it, Add removed-files.in part
[Checked in: Comment 5]

I feel safer deferring to KaiRo on this one, as I'm not sure on the "we should package x" for MSVC* stuff.
Attachment #474617 - Flags: review?(bugspam.Callek) → review?(kairo)
(Assignee)

Comment 3

7 years ago
KaiRo, ping for review.

Fwiw, TB has now ported bug 569268 in bug 630857.
Comment on attachment 474617 [details] [diff] [review]
(Av1) Just copy it, Add removed-files.in part
[Checked in: Comment 5]

actually stealing the review back; I have spent some time looking into related stuff recently. I'm not exactly LIKING the removed-files code here, but I agree it is "correct" (we could suffice with strictly what we ship, but no big deal).
Attachment #474617 - Flags: review?(kairo) → review+
(Assignee)

Comment 5

7 years ago
Comment on attachment 474617 [details] [diff] [review]
(Av1) Just copy it, Add removed-files.in part
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/489165ce4714
Attachment #474617 - Attachment description: (Av1) Just copy it, Add removed-files.in part → (Av1) Just copy it, Add removed-files.in part [Checked in: Comment 5]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
Is this an issue with b2, i.e. something for Known Issues?
(Assignee)

Comment 7

7 years ago
(In reply to comment #6)
> Is this an issue with b2, i.e. something for Known Issues?

It shouldn't be: our win32 release build uses jemalloc (mozcXX19.dll).
(Assignee)

Comment 8

7 years ago
(In reply to comment #0)
> This could probably be a bug 565774 duplicate

Actually, this bug should not help bug 565774 ... and it didn't.
No longer blocks: 565774
(Assignee)

Updated

6 years ago
Depends on: 526333
(Assignee)

Updated

6 years ago
Blocks: 713134
No longer depends on: 515374, 526333
You need to log in before you can comment on or make changes to this bug.