595759 - Port |Bug 569268 - Package correct Visual C++ CRT DLLs based on compiler version (fixes MSVCR100.dll error message on startup)| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284332817.1284339902.4598.gz&fulltext=1
WINNT 5.2 comm-central-trunk leak test build on 2010/09/12 16:06:57
{
Warning: package error or possible missing or unnecessary file: bin/Microsoft.VC80.CRT.manifest (package-manifest, 41).
Warning: package error or possible missing or unnecessary file: bin/msvcm80.dll (package-manifest, 42).
Warning: package error or possible missing or unnecessary file: bin/msvcp80.dll (package-manifest, 43).
Warning: package error or possible missing or unnecessary file: bin/msvcr80.dll (package-manifest, 44).

-bin/Microsoft.VC80.CRT.manifest
-bin/msvcm80.dll
-bin/msvcp80.dll
-bin/msvcr80.dll
}

This could probably be a bug 565774 duplicate, but I prefer to fill it separately, just in case.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Just copy it, Add removed-files.in part [Checked in: Comment 5]

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 474617 [details] [diff] [review]
(Av1) Just copy it, Add removed-files.in part
[Checked in: Comment 5]

I feel safer deferring to KaiRo on this one, as I'm not sure on the "we should package x" for MSVC* stuff.

Comment 3

[Serge Gautherie (:sgautherie)]

KaiRo, ping for review.

Fwiw, TB has now ported bug 569268 in bug 630857.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 474617 [details] [diff] [review]
(Av1) Just copy it, Add removed-files.in part
[Checked in: Comment 5]

actually stealing the review back; I have spent some time looking into related stuff recently. I'm not exactly LIKING the removed-files code here, but I agree it is "correct" (we could suffice with strictly what we ship, but no big deal).

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 474617 [details] [diff] [review]
(Av1) Just copy it, Add removed-files.in part
[Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/489165ce4714

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

Is this an issue with b2, i.e. something for Known Issues?

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> Is this an issue with b2, i.e. something for Known Issues?

It shouldn't be: our win32 release build uses jemalloc (mozcXX19.dll).

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> This could probably be a bug 565774 duplicate

Actually, this bug should not help bug 565774 ... and it didn't.